ContractExecutor changes #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntractExecutor, fix danling temp library file
edg-l
changed the title
edg-l
requested review from
igaray,
azteca1998,
jrchatruc,
entropidelic,
fmoletta,
Oppen and
pefontana
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #794 +/- ##
=======================================
Coverage 88.69% 88.70%
=======================================
Files 121 121
Lines 35512 35563 +51
=======================================
+ Hits 31499 31546 +47
- Misses 4013 4017 +4 ☔ View full report in Codecov by Sentry. |
Benchmarking resultsBenchmark for program
|
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
8.839 ± 0.067 | 8.745 | 8.940 | 18.35 ± 0.16 |
cairo-native (embedded AOT) |
3.149 ± 0.018 | 3.133 | 3.195 | 6.54 ± 0.05 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.165 ± 0.026 | 3.134 | 3.225 | 6.57 ± 0.06 |
cairo-native (standalone AOT) |
0.655 ± 0.004 | 0.652 | 0.664 | 1.36 ± 0.01 |
cairo-native (standalone AOT with -march=native) |
0.482 ± 0.002 | 0.480 | 0.487 | 1.00 |
Benchmark for program fib_2M
Open benchmarks
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
8.756 ± 0.077 | 8.647 | 8.886 | 1075.58 ± 23.74 |
cairo-native (embedded AOT) |
2.679 ± 0.027 | 2.643 | 2.728 | 329.11 ± 7.44 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.717 ± 0.057 | 2.665 | 2.801 | 333.73 ± 9.77 |
cairo-native (standalone AOT) |
0.009 ± 0.001 | 0.008 | 0.017 | 1.05 ± 0.08 |
cairo-native (standalone AOT with -march=native) |
0.008 ± 0.000 | 0.008 | 0.011 | 1.00 |
Benchmark for program logistic_map
Open benchmarks
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
4.294 ± 0.022 | 4.268 | 4.334 | 63.84 ± 0.35 |
cairo-native (embedded AOT) |
2.941 ± 0.029 | 2.911 | 3.009 | 43.72 ± 0.44 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.069 ± 0.019 | 3.043 | 3.102 | 45.62 ± 0.30 |
cairo-native (standalone AOT) |
0.108 ± 0.000 | 0.108 | 0.109 | 1.61 ± 0.00 |
cairo-native (standalone AOT with -march=native) |
0.067 ± 0.000 | 0.067 | 0.068 | 1.00 |
azteca1998
approved these changes
Sep 19, 2024
FrancoGiachetta
approved these changes
Sep 19, 2024
Comment on lines
+53
to
58
| if is_for_contract_executor { | ||
| Cow::Owned(format!("f{}", function_id.id)) | ||
| } else if let Some(name) = function_id.debug_name.as_deref() { | ||
| Cow::Owned(format!("{}(f{})", name, function_id.id)) | ||
| } else { | ||
| Cow::Owned(format!("f{}", function_id.id)) |
There was a problem hiding this comment.
I think the first if has the same behaviour as the else statement, may be it would be better to just remove it and just leave the if let {} else {} pattern?
There was a problem hiding this comment.
it's not exactly the same, because if is_for_contract_executor is true, it will always be that branch, however removing that and just having the if let else will make the debug name have priority even if is_for_contract_executor is true
There was a problem hiding this comment.
Ohh, I see you point. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to never have debug names in functions and enable it on ContractExecutor, fix dangling temp library file
Checklist