Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate syscall handler implementations into one (initial pr) #690

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

edg-l
Copy link
Member

@edg-l edg-l commented Jun 18, 2024

Partially fi_xes #649

edit: more syscall handlers can be replaced but it will grow the pr so ill make a followup one

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

Copy link

github-actions bot commented Jun 18, 2024

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.361 ± 0.076 11.264 11.487 23.51 ± 0.33
cairo-native (embedded AOT) 1.523 ± 0.019 1.501 1.558 3.15 ± 0.06
cairo-native (embedded JIT using LLVM's ORC Engine) 1.631 ± 0.023 1.602 1.659 3.37 ± 0.06
cairo-native (standalone AOT) 0.656 ± 0.006 0.651 0.673 1.36 ± 0.02
cairo-native (standalone AOT with -march=native) 0.483 ± 0.006 0.479 0.494 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 10.670 ± 0.046 10.618 10.766 1307.76 ± 16.97
cairo-native (embedded AOT) 1.175 ± 0.030 1.122 1.202 143.98 ± 4.09
cairo-native (embedded JIT using LLVM's ORC Engine) 1.166 ± 0.027 1.129 1.206 142.93 ± 3.70
cairo-native (standalone AOT) 0.008 ± 0.000 0.008 0.010 1.04 ± 0.02
cairo-native (standalone AOT with -march=native) 0.008 ± 0.000 0.008 0.009 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 1.879 ± 0.013 1.859 1.903 28.43 ± 0.24
cairo-native (embedded AOT) 1.240 ± 0.015 1.228 1.281 18.76 ± 0.25
cairo-native (embedded JIT using LLVM's ORC Engine) 1.413 ± 0.012 1.403 1.444 21.38 ± 0.20
cairo-native (standalone AOT) 0.107 ± 0.000 0.107 0.107 1.62 ± 0.01
cairo-native (standalone AOT with -march=native) 0.066 ± 0.000 0.066 0.068 1.00

@edg-l
Copy link
Member Author

edg-l commented Jun 18, 2024

more syscall handlers can be replaced but it will grow the pr so ill make a followup one

@edg-l edg-l marked this pull request as ready for review June 18, 2024 13:05
@edg-l edg-l changed the title Consolidate syscall handler implementations into one Consolidate syscall handler implementations into one (initial pr) Jun 18, 2024
@edg-l edg-l added the review-ready A PR that is ready for review label Jun 18, 2024
@igaray igaray added this pull request to the merge queue Jun 24, 2024
Merged via the queue into main with commit f681243 Jun 24, 2024
9 checks passed
@igaray igaray deleted the consolidate_syscallhandler branch June 24, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-ready A PR that is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants