Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LLVM_SYS_170_PREFIX export to env-macos.sh #359

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

fmoletta
Copy link
Collaborator

@fmoletta fmoletta commented Dec 5, 2023

Following the MacOs setup in the Getting Started section of the README leads to an error when running make test as the env var LLVM_SYS_170_PREFIX is not set. This PR adds this export to the env-macos.sh script.

@fmoletta fmoletta changed the title Add LLVM_SYS_170_PREFIX export to env-macos.sh Add LLVM_SYS_170_PREFIX export to env-macos.sh Dec 5, 2023
Copy link

github-actions bot commented Dec 5, 2023

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 20.839 ± 0.158 20.694 21.220 43.58 ± 0.38
cairo-native (JIT MLIR ORC Engine) 1.571 ± 0.015 1.545 1.591 3.28 ± 0.04
cairo-native (AOT Native binary) 0.661 ± 0.001 0.659 0.663 1.38 ± 0.01
cairo-native (AOT Native binary with host CPU features, march=native) 0.478 ± 0.002 0.477 0.484 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 20.286 ± 0.048 20.203 20.341 648.03 ± 3.82
cairo-native (JIT MLIR ORC Engine) 1.113 ± 0.012 1.097 1.130 35.57 ± 0.44
cairo-native (AOT Native binary) 0.031 ± 0.000 0.031 0.032 1.00 ± 0.01
cairo-native (AOT Native binary with host CPU features, march=native) 0.031 ± 0.000 0.031 0.032 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 1.903 ± 0.012 1.881 1.924 27.17 ± 0.19
cairo-native (JIT MLIR ORC Engine) 1.423 ± 0.021 1.394 1.459 20.31 ± 0.30
cairo-native (AOT Native binary) 0.110 ± 0.004 0.109 0.132 1.57 ± 0.06
cairo-native (AOT Native binary with host CPU features, march=native) 0.070 ± 0.000 0.070 0.071 1.00

@codecov-commenter
Copy link

Codecov Report

Attention: 149 lines in your changes are missing coverage. Please review.

Comparison is base (87d0c98) 74.27% compared to head (efaf1d6) 73.90%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/bin/cairo-native-compile.rs 0.00% 134 Missing ⚠️
src/ffi.rs 88.46% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #359      +/-   ##
==========================================
- Coverage   74.27%   73.90%   -0.37%     
==========================================
  Files          96       97       +1     
  Lines       21889    22153     +264     
==========================================
+ Hits        16257    16372     +115     
- Misses       5632     5781     +149     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@igaray igaray merged commit b7f4a77 into main Dec 5, 2023
7 checks passed
@igaray igaray deleted the add-llvm-sys-prefix-to-env-macos branch December 5, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants