-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
starknet: make more methods take mut self #316
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edg-l
requested review from
igaray,
azteca1998,
jrchatruc and
entropidelic
as code owners
October 11, 2023 12:48
Benchmarking resultsBenchmark for program
|
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
cairo-run --available-gas 18446744073709551615 -s programs/benches/factorial_100.cairo |
2.329 ± 0.085 | 2.200 | 2.479 | 2893.69 ± 706.95 |
echo '[null, 18446744073709551615]' | ./target/release/cairo-native-run programs/benches/factorial_100.cairo factorial_100::factorial_100::main --inputs - |
0.001 ± 0.000 | 0.001 | 0.004 | 1.79 ± 0.50 |
./target/bench-outputs/factorial_100 |
0.001 ± 0.000 | 0.001 | 0.006 | 1.01 ± 0.35 |
./target/bench-outputs/factorial_100-march-native |
0.001 ± 0.000 | 0.001 | 0.005 | 1.00 |
Benchmark for program fib_1k
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
cairo-run --available-gas 18446744073709551615 -s programs/benches/fib_1k.cairo |
2.356 ± 0.098 | 2.201 | 2.497 | 2799.47 ± 588.00 |
echo '[null, 18446744073709551615]' | ./target/release/cairo-native-run programs/benches/fib_1k.cairo fib_1k::fib_1k::main --inputs - |
0.001 ± 0.000 | 0.001 | 0.006 | 1.66 ± 0.46 |
./target/bench-outputs/fib_1k |
0.001 ± 0.000 | 0.001 | 0.006 | 1.00 |
./target/bench-outputs/fib_1k-march-native |
0.001 ± 0.000 | 0.001 | 0.006 | 1.02 ± 0.30 |
Benchmark for program map
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
cairo-run --available-gas 18446744073709551615 -s programs/benches/map.cairo |
2.479 ± 0.066 | 2.381 | 2.575 | 1691.32 ± 228.70 |
echo '[null, 18446744073709551615]' | ./target/release/cairo-native-run programs/benches/map.cairo map::map::main --inputs - |
0.001 ± 0.000 | 0.001 | 0.004 | 1.00 |
./target/bench-outputs/map |
0.076 ± 0.002 | 0.072 | 0.081 | 51.60 ± 7.02 |
./target/bench-outputs/map-march-native |
0.074 ± 0.002 | 0.071 | 0.081 | 50.31 ± 6.88 |
Codecov Report
@@ Coverage Diff @@
## free_ci_space #316 +/- ##
==============================================
Coverage 71.62% 71.62%
==============================================
Files 116 116
Lines 20617 20617
==============================================
Hits 14767 14767
Misses 5850 5850
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
edg-l
changed the title
make more methods take mut self
starknet: make more methods take mut self
Oct 11, 2023
igaray
previously approved these changes
Oct 17, 2023
igaray
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think most methods need to take &mut self to be implemented in sir.
Description
Description of the pull request changes and motivation.
Checklist