Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix instruction doc #317

Merged
merged 2 commits into from
Oct 23, 2023
Merged

fix instruction doc #317

merged 2 commits into from
Oct 23, 2023

Conversation

greged93
Copy link
Contributor

Based on the code and the Cairo paper page 32, the operand 1 source should be 3 bits and the opcode 3 bits. Corrected the docs in order to reflect this.

@greged93
Copy link
Contributor Author

hey @fmoletta can we merge this? I can't launch the CI

pefontana
pefontana approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@pefontana pefontana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the correction @greged93 !

@pefontana pefontana enabled auto-merge October 23, 2023 18:29
@pefontana pefontana added this pull request to the merge queue Oct 23, 2023
Merged via the queue into lambdaclass:main with commit 66a5863 Oct 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmoletta fmoletta fmoletta approved these changes

@pefontana pefontana pefontana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@greged93 @pefontana @fmoletta