Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing util CheckScopeVar #308

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Add testing util CheckScopeVar #308

merged 1 commit into from
Oct 2, 2023

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Sep 29, 2023

A single generic function to check that the execution scopes contains a certain value and its is equal to an expected value. Made to reduce boilerplate code in hint unit tests

@fmoletta fmoletta marked this pull request as ready for review September 29, 2023 14:58
@codecov-commenter
Copy link

Codecov Report

Merging #308 (f0d2396) into main (1697359) will decrease coverage by 0.37%.
Report is 3 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #308      +/-   ##
==========================================
- Coverage   56.40%   56.04%   -0.37%     
==========================================
  Files          47       48       +1     
  Lines        5992     6247     +255     
==========================================
+ Hits         3380     3501     +121     
- Misses       2286     2398     +112     
- Partials      326      348      +22     
Files Coverage Δ
pkg/hints/hint_utils/testing_utils.go 79.48% <0.00%> (-20.52%) ⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pefontana pefontana added this pull request to the merge queue Oct 2, 2023
Merged via the queue into main with commit 9cde79b Oct 2, 2023
2 checks passed
@pefontana pefontana deleted the CheckScope branch October 2, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants