Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VerifySecureRunner + SecureRun config flag #303

Merged
merged 37 commits into from
Oct 23, 2023
Merged

Add VerifySecureRunner + SecureRun config flag #303

merged 37 commits into from
Oct 23, 2023

Conversation

fmoletta
Copy link
Contributor

No description provided.

@fmoletta fmoletta changed the base branch from main to runFromEntrypoint September 27, 2023 21:07
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

Merging #303 (67924a2) into main (78c0a08) will decrease coverage by 0.08%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
- Coverage   56.19%   56.11%   -0.08%     
==========================================
  Files          48       49       +1     
  Lines        6316     6479     +163     
==========================================
+ Hits         3549     3636      +87     
- Misses       2407     2477      +70     
- Partials      360      366       +6     
Files Coverage Δ
pkg/runners/cairo_runner.go 47.08% <100.00%> (+0.13%) ⬆️
pkg/builtins/bitwise.go 49.71% <28.57%> (+3.28%) ⬆️
pkg/vm/cairo_run/cairo_run.go 17.47% <0.00%> (-0.90%) ⬇️
pkg/builtins/builtin_runner.go 80.30% <88.33%> (+80.30%) ⬆️
pkg/builtins/ec_op.go 43.77% <0.00%> (-1.12%) ⬇️
pkg/builtins/keccak.go 85.46% <0.00%> (-1.08%) ⬇️
pkg/builtins/pedersen.go 18.83% <0.00%> (-0.90%) ⬇️
pkg/builtins/poseidon.go 28.85% <0.00%> (-1.43%) ⬇️
pkg/builtins/range_check.go 23.80% <0.00%> (-0.92%) ⬇️
pkg/builtins/signature.go 5.19% <0.00%> (-0.25%) ⬇️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fmoletta fmoletta marked this pull request as ready for review September 28, 2023 20:16
Base automatically changed from runFromEntrypoint to execution-resources September 29, 2023 17:57
Base automatically changed from execution-resources to main September 29, 2023 18:48
Copy link
Contributor

@pefontana pefontana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a cairo_run_test example with secure_run == true?

@fmoletta
Copy link
Contributor Author

fmoletta commented Oct 3, 2023

Can you add a cairo_run_test example with secure_run == true?

secure_run should be always enabled if proof_mode is not, so Ill change the field in the testProgram utils

@pefontana pefontana added this pull request to the merge queue Oct 23, 2023
Merged via the queue into main with commit a629107 Oct 23, 2023
2 checks passed
@pefontana pefontana deleted the secure-run branch October 23, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants