Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExecutionResources + fix CairoRunner methods that received vm as an argument #300

Merged
merged 6 commits into from
Sep 29, 2023

Conversation

fmoletta
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

Merging #300 (d00239a) into main (8c01a73) will increase coverage by 0.07%.
The diff coverage is 55.22%.

@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
+ Coverage   56.11%   56.19%   +0.07%     
==========================================
  Files          48       48              
  Lines        6239     6316      +77     
==========================================
+ Hits         3501     3549      +48     
- Misses       2390     2407      +17     
- Partials      348      360      +12     
Files Coverage Δ
pkg/vm/cairo_run/cairo_run.go 18.36% <100.00%> (ø)
pkg/vm/vm_core.go 44.08% <50.00%> (+0.07%) ⬆️
pkg/vm/memory/segments.go 77.03% <84.00%> (+1.58%) ⬆️
pkg/runners/cairo_runner.go 46.95% <47.00%> (-0.41%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fmoletta fmoletta marked this pull request as ready for review September 27, 2023 18:33
fmoletta and others added 2 commits September 29, 2023 14:57
* Implement GenArg

* Remove recursive processing

* Add unit tests

* Fix test values

* Start fn

* Add RunFromEntryPoint

* Add test for RunFromEntryPoint

* Add unit tests

* Add comments
@pefontana pefontana added this pull request to the merge queue Sep 29, 2023
Merged via the queue into main with commit 78c0a08 Sep 29, 2023
2 checks passed
@pefontana pefontana deleted the execution-resources branch September 29, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants