Implement remaining hints in keccak module
#276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #276 +/- ##
==========================================
- Coverage 57.69% 57.13% -0.57%
==========================================
Files 45 45
Lines 5711 5853 +142
==========================================
+ Hits 3295 3344 +49
- Misses 2107 2192 +85
- Partials 309 317 +8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…nto keccak-hints-3
jrchatruc
approved these changes
Sep 21, 2023
Juan-M-V
approved these changes
Sep 26, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 26, 2023
* Add hint codes * Move divrem hint codes to math hint codes * Finish implementation of unsignedDivRem hint * Add some fields to range check builtin runner * WIP implementation of signedDivRem hint * Dummy commit * Save work in progress * Add FeltFromBigInt function * Add unsigned div rem integration test * Implement UnsafeKeccak * Update dependencies * Add unit test * Fix division bug and make integration test pass * Fix hash * Save work in progress * Add unit tests * Add integration test * Finished unit test for divrem hints * Remove unused commented code * Add missing file * Add constant + GetStructFieldRelocatable + start hint * Add test file * Add MemorySegmentManager.GetFeltRange * Progress * Finish hint * Add unit test * Add integration test * Remove nParts and bound from range check runner fields, add method to calculate bound from constant and add test to assert bound is never zero * Remove unused input parameter to NewRangeCheckBuiltinRunner * Change number to constant in Bound impl * Add hint + test * Add integration tests * Add hint + tests * Add hint * Fix test * Add test * Implement CAIRO_KECCAK_FINALIZE * Extract aliased constants * Fix index out of range * Fix var name * Make error more expressive * Fix hint * Add test, fix test * Add test files * Implement keccakWriteArgs * Extend hint parsing * Update program.go * Fix DivCeil * Add integration test * Fix DivCeil * v2 * Fix bug * Fix bug but better * Update keccak_add_uint256.cairo * Update cairo_run_test.go --------- Co-authored-by: Mariano Nicolini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #195