Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secp p hints #275

Merged
merged 63 commits into from
Sep 26, 2023
Merged

Secp p hints #275

merged 63 commits into from
Sep 26, 2023

Conversation

mmsc2
Copy link
Contributor

@mmsc2 mmsc2 commented Sep 20, 2023

No description provided.

mmsc2 and others added 30 commits September 14, 2023 15:37
@mmsc2
Add ec hints
977ba29
@mmsc2
Implement hints
70a9db2
@mmsc2
Add the hints to the processor
864b7b8
@mmsc2
Test pack86 function
7df4192
@mmsc2
Test hint
1a66309
@mmsc2
Delete debug info, Test ec negative op
91ffa57
@mmsc2
Second hint test
7bf1909
@mmsc2
Merge main
5d2d256
@mmsc2
Test embedded hint
a08c642
@mmsc2
Merge branch 'main' into EcHint
029fe50
@mmsc2
Merge branch 'main' into EcHint
762a566
@mmsc2
Change to Camel case
6c6eed9
@mmsc2
Implement slope hints
ec9345c
@mmsc2
Fix merge conflict
9d14678
@mmsc2
Fix format
ff7fb50
@mmsc2
Delete github conflict string
4e9afc5
@mmsc2
Tests hints
cc53b65
@mmsc2
Tests hints slopes
a0d269b
@mmsc2
Fix merge conflict
c25e25c
@mmsc2
Rename misleading name function
a27b814
@mmsc2
Merge branch 'main' into EcSlopeHint
51fedf0
@mmsc2
Fix function name
9e39502
@mmsc2
Fix format
327299b
@mmsc2
Fix error in function call
0fdad83
@entropidelic
Merge branch 'main' into EcSlopeHint
ba81ca8
@mmsc2
Delete debug info
78dd5d0
@mmsc2
Merge branch 'EcSlopeHint' of github.com:lambdaclass/cairo-vm.go into…
c023bea 
… EcSlopeHint
@mmsc2
Delete unused import
facfb8a
@mmsc2
Merge main
f195395
@mmsc2
Secp hints
76c8b8b
@mmsc2 mmsc2 marked this pull request as ready for review September 26, 2023 15:34
fmoletta
fmoletta reviewed Sep 26, 2023
View reviewed changes
pkg/hints/ec_hint_test.go Outdated Show resolved Hide resolved
fmoletta
fmoletta reviewed Sep 26, 2023
View reviewed changes
pkg/hints/ec_hint.go Outdated Show resolved Hide resolved
fmoletta
fmoletta reviewed Sep 26, 2023
View reviewed changes
pkg/hints/ec_hint.go Outdated Show resolved Hide resolved
fmoletta
fmoletta reviewed Sep 26, 2023
View reviewed changes
pkg/hints/field_utils.go Outdated Show resolved Hide resolved
fmoletta
fmoletta reviewed Sep 26, 2023
View reviewed changes
Copy link
Contributor

@fmoletta fmoletta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use camelCase for variable names

fmoletta
fmoletta reviewed Sep 26, 2023
View reviewed changes
pkg/hints/bigint_utils.go Outdated Show resolved Hide resolved
fmoletta
fmoletta reviewed Sep 26, 2023
View reviewed changes
pkg/hints/field_utils.go Outdated Show resolved Hide resolved
@fmoletta fmoletta mentioned this pull request Sep 26, 2023
Merged
jrchatruc
jrchatruc reviewed Sep 26, 2023
View reviewed changes
pkg/hints/ec_hint.go Outdated Show resolved Hide resolved
@mmsc2 mmsc2 added this pull request to the merge queue Sep 26, 2023
@mmsc2 mmsc2 removed this pull request from the merge queue due to a manual request Sep 26, 2023
@mmsc2 mmsc2 added this pull request to the merge queue Sep 26, 2023
Merged via the queue into main with commit 8a6c949 Sep 26, 2023
2 checks passed
@mmsc2 mmsc2 deleted the SecpPHints branch September 26, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrchatruc jrchatruc jrchatruc approved these changes

@fmoletta fmoletta fmoletta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mmsc2 @codecov-commenter @jrchatruc @fmoletta @entropidelic