Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement UNSAFE_KECCAK_FINALIZE hint #271

Merged
merged 17 commits into from
Sep 20, 2023
Merged

Implement UNSAFE_KECCAK_FINALIZE hint #271

merged 17 commits into from
Sep 20, 2023

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Sep 19, 2023

Depends on #246 & #272

@fmoletta fmoletta changed the title Implement `UNSAFE_KECCAK_FINALIZE;\' hint Implement `UNSAFE_KECCAK_FINALIZE' hint Sep 19, 2023
@fmoletta fmoletta changed the base branch from main to keccak-hints September 19, 2023 20:49
@fmoletta fmoletta changed the title Implement `UNSAFE_KECCAK_FINALIZE' hint Implement UNSAFE_KECCAK_FINALIZE hint Sep 19, 2023
@fmoletta fmoletta marked this pull request as ready for review September 19, 2023 21:27
Base automatically changed from keccak-hints to main September 20, 2023 16:16
@codecov-commenter
Copy link

Codecov Report

Merging #271 (e286be0) into main (067f139) will increase coverage by 58.56%.
The diff coverage is 46.29%.

@@            Coverage Diff            @@
##           main     #271       +/-   ##
=========================================
+ Coverage      0   58.56%   +58.56%     
=========================================
  Files         0       41       +41     
  Lines         0     5247     +5247     
=========================================
+ Hits          0     3073     +3073     
- Misses        0     1918     +1918     
- Partials      0      256      +256     
Files Changed Coverage Δ
pkg/hints/hint_utils/ids_manager.go 68.13% <0.00%> (ø)
pkg/hints/keccak_hints.go 61.29% <56.09%> (ø)
pkg/hints/hint_processor.go 98.19% <100.00%> (ø)

... and 38 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fmoletta fmoletta added this pull request to the merge queue Sep 20, 2023
Merged via the queue into main with commit 1cdb017 Sep 20, 2023
2 checks passed
@fmoletta fmoletta deleted the keccak-hints-2 branch September 20, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants