Ec slope hint #257
Merged
Ec slope hint #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
fmoletta
reviewed
Sep 19, 2023
I just try but there is still unimplemented hints to do an integration test |
Codecov Report
@@ Coverage Diff @@
## main #257 +/- ##
==========================================
+ Coverage 58.61% 58.75% +0.14%
==========================================
Files 41 42 +1
Lines 5318 5383 +65
==========================================
+ Hits 3117 3163 +46
- Misses 1937 1947 +10
- Partials 264 273 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jrchatruc
approved these changes
Sep 21, 2023
|
A general comment for the whole PR, let's be consistent with the naming conventions, like using camel case and shorter names when applicable (for example, |
|
other than the namings, PR looks good 👍 |
pkg/hints/ec_hint.go
Outdated
| func BigInt3FromVarName(name string, virtual_machine vm.VirtualMachine, ids_data hint_utils.IdsManager) (EcPoint, error) { | ||
| point_addr, err := ids_data.GetAddr(name, &virtual_machine) | ||
| func EcPointFromVarName(name string, vm VirtualMachine, idsData IdsManager) (EcPoint, error) { | ||
| point_addr, err := idsData.GetAddr(name, &vm) |
pkg/hints/ec_hint.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| y_bigint3, err := BigInt3FromBaseAddr(point_y, virtual_machine) | ||
| y_bigint3, err := BigInt3FromBaseAddr(pointY, vm) |
entropidelic
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.