Implement ASSERT_LT_FELT hint #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m.go into add-constants-to-ids
mmsc2
reviewed
Sep 19, 2023
pkg/hints/math_hints.go
Outdated
| return err | ||
| } | ||
| // Hint Logic | ||
| cairoPrime, _ := new(big.Int).SetString(CAIRO_PRIME_HEX, 0) |
There was a problem hiding this comment.
why the base of SetString is 0? should not be 16 if converting an hex value?
There was a problem hiding this comment.
CAIRO_PRIME_HEX starts with "0x", and SetString uses the prefix to determine the base if base is 0
jrchatruc
approved these changes
Sep 20, 2023
Juan-M-V
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #240 & #233 (Contains changes from both, please wait until one of them is merged into main and switch base accordingly to merge into base branch)
Closes #182