Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set_add hint #241

Merged
merged 21 commits into from
Sep 22, 2023
Merged

Add set_add hint #241

merged 21 commits into from
Sep 22, 2023

Conversation

Juan-M-V
Copy link
Contributor

@Juan-M-V Juan-M-V commented Sep 18, 2023

Resolves: #190

@Juan-M-V Juan-M-V marked this pull request as ready for review September 20, 2023 19:50
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Merging #241 (65d35d1) into main (f45d095) will decrease coverage by 0.49%.
The diff coverage is 45.36%.

@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
- Coverage   58.03%   57.54%   -0.49%     
==========================================
  Files          43       45       +2     
  Lines        5423     5611     +188     
==========================================
+ Hits         3147     3229      +82     
- Misses       2004     2080      +76     
- Partials      272      302      +30     
Files Changed Coverage Δ
pkg/vm/memory/memory.go 63.93% <0.00%> (-5.10%) ⬇️
pkg/hints/set_hints.go 31.81% <31.81%> (ø)
pkg/hints/find_element_hints.go 43.22% <43.22%> (ø)
pkg/hints/hint_processor.go 98.42% <100.00%> (+0.07%) ⬆️
pkg/lambdaworks/lambdaworks.go 91.26% <100.00%> (+0.39%) ⬆️
pkg/vm/vm_core.go 43.35% <100.00%> (+0.12%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

pkg/vm/memory/memory.go Outdated Show resolved Hide resolved
Copy link
Contributor

@fmoletta fmoletta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move find_element_hint_codes.go & set_hint_codes.go to the hint_codes folder
Also, many functions and variables are using snake_case instead of camelCase

pkg/vm/memory/memory.go Outdated Show resolved Hide resolved
@Juan-M-V
Copy link
Contributor Author

Please move find_element_hint_codes.go & set_hint_codes.go to the hint_codes folder Also, many functions and variables are using snake_case instead of camelCase

Moved hint codes to the hint_codes directory: f2ed685
Changed sake case to camel case: 1475d36

@fmoletta fmoletta added this pull request to the merge queue Sep 22, 2023
Merged via the queue into main with commit 6c1fd10 Sep 22, 2023
2 checks passed
@fmoletta fmoletta deleted the set-find-element-hint branch September 22, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add set and find_element module hints
4 participants