Implement DICT_SQUASH_COPY_DICT, DICT_SQUASH_UPDATE_PTR & DICT_NEW
#231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoletta
changed the title
DICT_SQUASH_COPY_DICT, DICT_SQUASH_UPDATE_PTR & DICT_NEW
jrchatruc
approved these changes
Sep 18, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
* First commit * Add testing * Add test * Add tests * Implement `ASSERT_NOT_EQUAL` hint * Add unit tests * Add integration test * Add tests * Add tests * Add test * Add minor changes * Implement vm_enter_scope hint and test * Changes attributes visibility and removes unused methods. * Fix string * Add newline at eof * Remove extra line * deletes duplicate code * Remove initial_dict from default-dict_new * fix test * Implement defaultDictNew * merge files * Integrate ExecutionScopes into hintProcessor logic * add test * Fixes + add test * Add test * Remove commented fn * Implement dictRead * Add tests * Add test * Store DictTrackers by reference to allow modifications * Add test file * Revert "Implement `ASSERT_NOT_EQUAL` hint" This reverts commit 2cfe447. * Revert "Add unit tests" This reverts commit 8a25e3d. * Remove leftovers from base branch * Remove leftovers from base branch * Fix eof * Implement DictUpdate * Add unit tests * Add integration test * Dont ignore errors * Fix DictWrite hint * Add hint codes * Implement DivRem, ModFloor, DivFloor * solve conflicts * Add Felt.Cmp * Implmenet squash_dict hint * add test * Start test * Complete test * Add fix + test * Add Fix + Test * Add tests * Implement SQUASH_DICT_INNER_FIRST_ITERATION * Add test * Add test * Implement hint * Add test * Test * Add Hint + tests * Add tests * Add hint + test * remove ExecutionScopes.Data() method * Add hint + test * More tests * Add integration test * Fix test * Fix hint code * Fix string * Check map is empty instead of map exists * Fix tests * Fix fmt * Fix comments * Move up check * Implement `DICT_SQUASH_COPY_DICT`, `DICT_SQUASH_UPDATE_PTR` & `DICT_NEW` (#231) * Implement dict squash copy dict hint * Add test * Add test * Add hint * Add test * Add hint * Add test * Add test, fix string * Add test file * Add newline at eof --------- Co-authored-by: toni-calvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #188
Depends on #218