Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memcpy hints #230

Merged
merged 27 commits into from
Sep 20, 2023
Merged

Memcpy hints #230

merged 27 commits into from
Sep 20, 2023

Conversation

toni-calvin
Copy link
Contributor

closes #180

@toni-calvin toni-calvin marked this pull request as ready for review September 19, 2023 12:06
toni-calvin
toni-calvin commented Sep 19, 2023
View reviewed changes
pkg/hints/hint_utils/ids_manager.go Outdated
Copy link
Contributor Author

@toni-calvin toni-calvin Sep 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I do this? The main reason is to check the error from tests and to "abstract" them a little bit, but I feel I am adding noise to the code and maybe it is not worth it.
If you feel the same i can revert the commit and not implementing it in future prs 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good!
Although it might be a good idea to open an issue to make sure we use these error functions on other hints

Juan-M-V
Juan-M-V reviewed Sep 19, 2023
View reviewed changes
pkg/hints/memcpy_hints.go Outdated Show resolved Hide resolved
@Juan-M-V
Copy link
Contributor

Nice work! I would like for you to add this integration test though. I've tried to run it locally and it seems to be halting

fmoletta
fmoletta reviewed Sep 19, 2023
View reviewed changes
pkg/hints/memcpy_hints.go Outdated Show resolved Hide resolved
fmoletta
fmoletta reviewed Sep 19, 2023
View reviewed changes
pkg/hints/memcpy_hints.go Outdated Show resolved Hide resolved
@toni-calvin
Copy link
Contributor Author

toni-calvin commented Sep 19, 2023 •
edited
Loading

Nice work! I would like for you to add this integration test though. I've tried to run it locally and it seems to be halting

Thank you! 👍 done!

@fmoletta fmoletta added this pull request to the merge queue Sep 19, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Sep 19, 2023
@toni-calvin toni-calvin added this pull request to the merge queue Sep 20, 2023
Merged via the queue into main with commit 64dcc86 Sep 20, 2023
2 checks passed
@toni-calvin toni-calvin deleted the memcpy-hints branch September 20, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Juan-M-V Juan-M-V Juan-M-V approved these changes

@fmoletta fmoletta fmoletta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memcpy/Memset hints
3 participants
@toni-calvin @Juan-M-V @fmoletta