Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement IS_QUAD_RESIDUE hint #216

Merged
merged 61 commits into from
Sep 18, 2023
Merged

Implement IS_QUAD_RESIDUE hint #216

merged 61 commits into from
Sep 18, 2023

Conversation

pefontana
Copy link
Contributor

@pefontana pefontana commented Sep 13, 2023 •
edited
Loading

Implement IS_QUAD_RESIDUE hint

  • Add lambdaworks FFII:

    • func SignedFeltMaxValue()
    • func (a Felt) Pow(p Felt) Felt
    • func (a Felt) Sqrt() Felt

  • Implement IS_QUAD_RESIDUE hint

Issue: #184

mmsc2 and others added 30 commits August 11, 2023 13:16
@mmsc2
EcOp Builtin
30e2e67
@mmsc2
Change b for ec in methods
32950cb
@mmsc2
Change name
91695a3
@mmsc2
Merge branch 'main' into EcOpBuiltin
96d0a6c
@mmsc2
implement shift left for felt
6c3f5ee
@mmsc2
Implement Decude memory cell
af96293
@mmsc2
deduced memory cell
95e6349
@mmsc2
Add pow function
aa3f158
@mmsc2
Add pow tests
c2675ea
@mmsc2
Add point on curve
951209c
@mmsc2
Merge branch 'main' into EcOpBuiltin
f06e6ba
@mmsc2
implement math functions
428bfd8
@mmsc2
Math functions
a048726
@mmsc2
Ec double point
c3fe6a1
@mmsc2
Test for point on curve
d513194
@mmsc2
merge main
4bab01d
@mmsc2
Test ec on impl
1884435
@mmsc2
debug info
f0e857f
Add DivMod func
70a99bc
Merge branch 'main' of github.com:lambdaclass/cairo-vm.go into implem…
4320a09 
…ent-div-mod-func
make fmt
092e658
@mmsc2
Fix and error
368f9d5
@mmsc2
Merge branch 'implement-div-mod-func' into EcOpBuiltin
03cdc7d
@mmsc2
Fix ec impl function, add div mod of math utils
ada0266
@mmsc2
Fix format, delete debug info
2a702f4
@mmsc2
Delete prints in test
9d7d605
@mmsc2
Add more tests
b39dd2f
@mmsc2
Merge main
2decb87
@mmsc2
Add deduce memory cell tests
af19748
@mmsc2
Fix format of tests
4c6268b
@pefontana pefontana changed the base branch from main to EcOpBuiltin September 13, 2023 22:03
Base automatically changed from EcOpBuiltin to main September 14, 2023 15:24
@pefontana pefontana linked an issue Sep 15, 2023 that may be closed by this pull request
IS_QUAD_RESIDUE #184
Closed
@pefontana pefontana marked this pull request as ready for review September 15, 2023 19:14
@pefontana pefontana added this pull request to the merge queue Sep 18, 2023
Merged via the queue into main with commit 5871d4a Sep 18, 2023
@pefontana pefontana deleted the hint_is_quad_residue branch September 18, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Juan-M-V Juan-M-V Juan-M-V approved these changes

@jrchatruc jrchatruc jrchatruc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IS_QUAD_RESIDUE
5 participants
@pefontana @jrchatruc @Juan-M-V @mmsc2 @entropidelic