Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix entrypoint offset in test #1904

Merged
merged 8 commits into from
Dec 27, 2024
Merged

Fix entrypoint offset in test #1904

merged 8 commits into from
Dec 27, 2024

Conversation

FrancoGiachetta
Copy link
Contributor

Fix entrypoint offset in test

Description

This PR changes the offset used in test test_uint256_div_mod_hint which seems to have been change after updating cairo-lang

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@FrancoGiachetta FrancoGiachetta added the tests Implementation of tests label Dec 27, 2024
@FrancoGiachetta FrancoGiachetta marked this pull request as ready for review December 27, 2024 12:50
Copy link

github-actions bot commented Dec 27, 2024

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     31.723 s ±  0.026 s    [User: 30.882 s, System: 0.839 s]
  Range (min … max):   31.705 s … 31.742 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     32.227 s ±  0.754 s    [User: 31.391 s, System: 0.833 s]
  Range (min … max):   31.694 s … 32.760 s    2 runs
 
Summary
  hyper_threading_main threads: 1 ran
    1.02 ± 0.02 times faster than hyper_threading_pr threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     17.654 s ±  0.013 s    [User: 30.841 s, System: 0.867 s]
  Range (min … max):   17.645 s … 17.663 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     17.650 s ±  0.020 s    [User: 30.759 s, System: 0.829 s]
  Range (min … max):   17.635 s … 17.664 s    2 runs
 
Summary
  hyper_threading_pr threads: 2 ran
    1.00 ± 0.00 times faster than hyper_threading_main threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     11.998 s ±  0.325 s    [User: 43.548 s, System: 0.985 s]
  Range (min … max):   11.769 s … 12.228 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     12.311 s ±  0.604 s    [User: 43.569 s, System: 0.994 s]
  Range (min … max):   11.884 s … 12.737 s    2 runs
 
Summary
  hyper_threading_main threads: 4 ran
    1.03 ± 0.06 times faster than hyper_threading_pr threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     12.257 s ±  0.177 s    [User: 43.210 s, System: 1.049 s]
  Range (min … max):   12.132 s … 12.382 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     11.888 s ±  0.045 s    [User: 43.872 s, System: 1.020 s]
  Range (min … max):   11.856 s … 11.919 s    2 runs
 
Summary
  hyper_threading_pr threads: 6 ran
    1.03 ± 0.02 times faster than hyper_threading_main threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     11.909 s ±  0.294 s    [User: 43.792 s, System: 1.027 s]
  Range (min … max):   11.701 s … 12.117 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     11.999 s ±  0.429 s    [User: 44.186 s, System: 1.028 s]
  Range (min … max):   11.696 s … 12.302 s    2 runs
 
Summary
  hyper_threading_main threads: 8 ran
    1.01 ± 0.04 times faster than hyper_threading_pr threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     12.045 s ±  0.163 s    [User: 43.988 s, System: 1.133 s]
  Range (min … max):   11.930 s … 12.161 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     11.955 s ±  0.425 s    [User: 44.346 s, System: 1.132 s]
  Range (min … max):   11.654 s … 12.256 s    2 runs
 
Summary
  hyper_threading_pr threads: 16 ran
    1.01 ± 0.04 times faster than hyper_threading_main threads: 16


Copy link

github-actions bot commented Dec 27, 2024

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.636 ± 0.077 2.543 2.804 1.04 ± 0.03
head big_factorial 2.539 ± 0.034 2.493 2.603 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.545 ± 0.063 2.497 2.679 1.02 ± 0.03
head big_fibonacci 2.493 ± 0.038 2.438 2.581 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 9.583 ± 0.514 9.209 10.815 1.04 ± 0.06
head blake2s_integration_benchmark 9.217 ± 0.049 9.142 9.302 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.663 ± 0.048 2.620 2.773 1.01 ± 0.03
head compare_arrays_200000 2.634 ± 0.045 2.582 2.720 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.763 ± 0.040 1.737 1.869 1.03 ± 0.03
head dict_integration_benchmark 1.708 ± 0.019 1.685 1.737 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.448 ± 0.016 1.432 1.482 1.01 ± 0.01
head field_arithmetic_get_square_benchmark 1.440 ± 0.009 1.423 1.451 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 9.431 ± 0.335 9.244 10.317 1.01 ± 0.04
head integration_builtins 9.321 ± 0.072 9.221 9.450 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 9.654 ± 0.216 9.532 10.244 1.00
head keccak_integration_benchmark 9.715 ± 0.059 9.610 9.780 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.733 ± 0.059 2.664 2.871 1.02 ± 0.03
head linear_search 2.668 ± 0.032 2.634 2.750 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.835 ± 0.016 1.819 1.873 1.02 ± 0.01
head math_cmp_and_pow_integration_benchmark 1.804 ± 0.019 1.773 1.842 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.787 ± 0.016 1.767 1.810 1.03 ± 0.01
head math_integration_benchmark 1.739 ± 0.010 1.722 1.754 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.510 ± 0.031 1.480 1.580 1.03 ± 0.02
head memory_integration_benchmark 1.472 ± 0.017 1.450 1.503 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.882 ± 0.014 1.863 1.909 1.02 ± 0.01
head operations_with_data_structures_benchmarks 1.849 ± 0.021 1.826 1.894 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 601.8 ± 8.8 591.5 623.3 1.01 ± 0.02
head pedersen 596.4 ± 3.4 592.5 601.9 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 704.1 ± 3.9 698.0 709.0 1.00
head poseidon_integration_benchmark 708.3 ± 13.9 694.5 738.0 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 2.117 ± 0.019 2.093 2.146 1.01 ± 0.02
head secp_integration_benchmark 2.102 ± 0.030 2.072 2.175 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 700.0 ± 4.8 692.1 707.5 1.01 ± 0.01
head set_integration_benchmark 694.0 ± 7.3 687.5 713.3 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 5.188 ± 0.037 5.142 5.234 1.00 ± 0.01
head uint256_integration_benchmark 5.178 ± 0.060 5.088 5.292 1.00

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.33%. Comparing base (9aa0a5f) to head (02bd805).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1904   +/-   ##
=======================================
  Coverage   96.33%   96.33%           
=======================================
  Files         102      102           
  Lines       40751    40751           
=======================================
  Hits        39259    39259           
  Misses       1492     1492           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pefontana pefontana added this pull request to the merge queue Dec 27, 2024
Merged via the queue into main with commit 404d763 Dec 27, 2024
82 checks passed
@pefontana pefontana deleted the fix-test branch December 27, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Implementation of tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants