Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stavbe: change AirPrivateInputSerializable fields to public #1900

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

stavbe: change AirPrivateInputSerializable fields to public #1900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

#### [2.0.0-rc2] - 2024-12-12

* chore: Expose fields in `AirPrivateInputSerializable` as public for external access [#1900] (https://github.com/lambdaclass/cairo-vm/pull/1900)

* fix: Change wildcard getrandom dependency.

* Update starknet-crypto to 0.7.3, removing the old FieldElement completly in favour of the new Felt (that is Copy).
Expand Down
24 changes: 12 additions & 12 deletions vm/src/air_private_input.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,28 +12,28 @@ use crate::Felt252;
// Serializable format, matches the file output of the python implementation
#[derive(Serialize, Deserialize, Clone, Debug, PartialEq, Eq)]
pub struct AirPrivateInputSerializable {
trace_path: String,
memory_path: String,
pub trace_path: String,
pub memory_path: String,
#[serde(skip_serializing_if = "Option::is_none")]
pedersen: Option<Vec<PrivateInput>>,
pub pedersen: Option<Vec<PrivateInput>>,
#[serde(skip_serializing_if = "Option::is_none")]
range_check: Option<Vec<PrivateInput>>,
pub range_check: Option<Vec<PrivateInput>>,
#[serde(skip_serializing_if = "Option::is_none")]
range_check96: Option<Vec<PrivateInput>>,
pub range_check96: Option<Vec<PrivateInput>>,
#[serde(skip_serializing_if = "Option::is_none")]
ecdsa: Option<Vec<PrivateInput>>,
pub ecdsa: Option<Vec<PrivateInput>>,
#[serde(skip_serializing_if = "Option::is_none")]
bitwise: Option<Vec<PrivateInput>>,
pub bitwise: Option<Vec<PrivateInput>>,
#[serde(skip_serializing_if = "Option::is_none")]
ec_op: Option<Vec<PrivateInput>>,
pub ec_op: Option<Vec<PrivateInput>>,
#[serde(skip_serializing_if = "Option::is_none")]
keccak: Option<Vec<PrivateInput>>,
pub keccak: Option<Vec<PrivateInput>>,
#[serde(skip_serializing_if = "Option::is_none")]
poseidon: Option<Vec<PrivateInput>>,
pub poseidon: Option<Vec<PrivateInput>>,
#[serde(skip_serializing_if = "Option::is_none")]
add_mod: Option<PrivateInput>,
pub add_mod: Option<PrivateInput>,
#[serde(skip_serializing_if = "Option::is_none")]
mul_mod: Option<PrivateInput>,
pub mul_mod: Option<PrivateInput>,
}

// Contains only builtin public inputs, useful for library users
Expand Down