Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS #1879

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Update CODEOWNERS #1879

merged 1 commit into from
Nov 22, 2024

Conversation

gabrielbosio
Copy link
Collaborator

No description provided.

Copy link

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     31.966 s ±  0.045 s    [User: 31.214 s, System: 0.750 s]
  Range (min … max):   31.934 s … 31.998 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     32.352 s ±  0.018 s    [User: 31.572 s, System: 0.778 s]
  Range (min … max):   32.340 s … 32.365 s    2 runs
 
Summary
  'hyper_threading_main threads: 1' ran
    1.01 ± 0.00 times faster than 'hyper_threading_pr threads: 1'




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     17.621 s ±  0.046 s    [User: 30.937 s, System: 0.734 s]
  Range (min … max):   17.589 s … 17.654 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     17.843 s ±  0.031 s    [User: 31.218 s, System: 0.785 s]
  Range (min … max):   17.821 s … 17.864 s    2 runs
 
Summary
  'hyper_threading_main threads: 2' ran
    1.01 ± 0.00 times faster than 'hyper_threading_pr threads: 2'




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     12.522 s ±  0.027 s    [User: 43.129 s, System: 0.922 s]
  Range (min … max):   12.503 s … 12.541 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     12.371 s ±  0.423 s    [User: 43.636 s, System: 0.954 s]
  Range (min … max):   12.071 s … 12.670 s    2 runs
 
Summary
  'hyper_threading_pr threads: 4' ran
    1.01 ± 0.03 times faster than 'hyper_threading_main threads: 4'




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     12.044 s ±  0.241 s    [User: 43.698 s, System: 0.833 s]
  Range (min … max):   11.874 s … 12.214 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     11.842 s ±  0.072 s    [User: 43.812 s, System: 0.964 s]
  Range (min … max):   11.790 s … 11.893 s    2 runs
 
Summary
  'hyper_threading_pr threads: 6' ran
    1.02 ± 0.02 times faster than 'hyper_threading_main threads: 6'




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     11.909 s ±  0.120 s    [User: 44.188 s, System: 1.008 s]
  Range (min … max):   11.824 s … 11.995 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     11.843 s ±  0.102 s    [User: 44.161 s, System: 0.973 s]
  Range (min … max):   11.771 s … 11.916 s    2 runs
 
Summary
  'hyper_threading_pr threads: 8' ran
    1.01 ± 0.01 times faster than 'hyper_threading_main threads: 8'




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     11.925 s ±  0.098 s    [User: 44.204 s, System: 1.063 s]
  Range (min … max):   11.856 s … 11.995 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     11.666 s ±  0.032 s    [User: 44.599 s, System: 1.010 s]
  Range (min … max):   11.643 s … 11.688 s    2 runs
 
Summary
  'hyper_threading_pr threads: 16' ran
    1.02 ± 0.01 times faster than 'hyper_threading_main threads: 16'


Copy link

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.473 ± 0.021 2.453 2.502 1.00
head big_factorial 2.495 ± 0.039 2.465 2.600 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.440 ± 0.049 2.404 2.551 1.01 ± 0.02
head big_fibonacci 2.421 ± 0.016 2.404 2.455 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 9.177 ± 0.080 9.062 9.300 1.00
head blake2s_integration_benchmark 9.187 ± 0.080 9.028 9.279 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.575 ± 0.050 2.539 2.714 1.00 ± 0.03
head compare_arrays_200000 2.574 ± 0.049 2.523 2.689 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.675 ± 0.023 1.657 1.736 1.00
head dict_integration_benchmark 1.714 ± 0.035 1.683 1.786 1.02 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.430 ± 0.020 1.407 1.468 1.00
head field_arithmetic_get_square_benchmark 1.439 ± 0.037 1.413 1.541 1.01 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 9.353 ± 0.360 9.095 10.174 1.02 ± 0.05
head integration_builtins 9.194 ± 0.207 9.065 9.770 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 9.621 ± 0.346 9.453 10.598 1.01 ± 0.04
head keccak_integration_benchmark 9.505 ± 0.114 9.346 9.705 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.590 ± 0.069 2.539 2.734 1.01 ± 0.03
head linear_search 2.573 ± 0.041 2.545 2.679 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.769 ± 0.058 1.721 1.874 1.00 ± 0.04
head math_cmp_and_pow_integration_benchmark 1.768 ± 0.042 1.728 1.832 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.691 ± 0.039 1.657 1.763 1.00
head math_integration_benchmark 1.691 ± 0.018 1.679 1.740 1.00 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.436 ± 0.017 1.410 1.471 1.01 ± 0.02
head memory_integration_benchmark 1.422 ± 0.014 1.406 1.446 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.800 ± 0.025 1.778 1.865 1.00
head operations_with_data_structures_benchmarks 1.801 ± 0.006 1.789 1.807 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 585.2 ± 2.7 581.5 589.7 1.00
head pedersen 588.3 ± 5.9 582.5 602.6 1.01 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 696.6 ± 6.0 691.2 712.3 1.00
head poseidon_integration_benchmark 697.8 ± 3.0 692.9 702.6 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 2.067 ± 0.032 2.047 2.153 1.00 ± 0.02
head secp_integration_benchmark 2.060 ± 0.011 2.051 2.085 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 679.2 ± 5.3 673.2 690.7 1.00
head set_integration_benchmark 680.5 ± 5.3 673.8 693.1 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 5.046 ± 0.032 5.012 5.103 1.00
head uint256_integration_benchmark 5.050 ± 0.061 4.981 5.202 1.00 ± 0.01

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.33%. Comparing base (388a4e5) to head (6848e18).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1879   +/-   ##
=======================================
  Coverage   96.33%   96.33%           
=======================================
  Files         102      102           
  Lines       40687    40687           
=======================================
  Hits        39195    39195           
  Misses       1492     1492           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@gabrielbosio gabrielbosio added the pipelines This PR/issue is exclusively about improving our CI label Nov 22, 2024
@pefontana pefontana enabled auto-merge November 22, 2024 15:42
@pefontana pefontana added this pull request to the merge queue Nov 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 22, 2024
@gabrielbosio gabrielbosio added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit 0b30ba2 Nov 22, 2024
73 of 74 checks passed
@gabrielbosio gabrielbosio deleted the update_codeowners branch November 22, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pipelines This PR/issue is exclusively about improving our CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants