Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test using range_check96, add_mod & mul_mod builtins #1699

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Apr 4, 2024

No description provided.

@fmoletta fmoletta added the tests Implementation of tests label Apr 4, 2024
Copy link

github-actions bot commented Apr 5, 2024

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.316 ± 0.019 2.295 2.347 1.00
head big_factorial 2.319 ± 0.021 2.297 2.360 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.302 ± 0.019 2.275 2.329 1.00
head big_fibonacci 2.323 ± 0.032 2.293 2.405 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 8.695 ± 0.164 8.417 8.827 1.00
head blake2s_integration_benchmark 8.740 ± 0.316 8.406 9.485 1.01 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.378 ± 0.046 2.347 2.505 1.00
head compare_arrays_200000 2.397 ± 0.030 2.375 2.471 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.484 ± 0.015 1.467 1.514 1.00
head dict_integration_benchmark 1.495 ± 0.020 1.477 1.536 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.335 ± 0.012 1.319 1.349 1.00
head field_arithmetic_get_square_benchmark 1.336 ± 0.024 1.306 1.382 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.735 ± 0.390 8.410 9.744 1.01 ± 0.05
head integration_builtins 8.683 ± 0.224 8.452 9.156 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.879 ± 0.182 8.663 9.076 1.00
head keccak_integration_benchmark 8.986 ± 0.418 8.668 10.035 1.01 ± 0.05
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.427 ± 0.020 2.401 2.466 1.01 ± 0.01
head linear_search 2.406 ± 0.019 2.387 2.454 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.613 ± 0.011 1.599 1.630 1.00
head math_cmp_and_pow_integration_benchmark 1.627 ± 0.025 1.600 1.688 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.477 ± 0.031 1.437 1.535 1.01 ± 0.03
head math_integration_benchmark 1.461 ± 0.019 1.446 1.498 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.303 ± 0.014 1.285 1.330 1.01 ± 0.01
head memory_integration_benchmark 1.293 ± 0.010 1.281 1.312 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.668 ± 0.029 1.634 1.722 1.01 ± 0.02
head operations_with_data_structures_benchmarks 1.646 ± 0.017 1.631 1.687 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 598.6 ± 7.4 592.8 618.7 1.00
head pedersen 603.7 ± 14.3 595.8 638.8 1.01 ± 0.03
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 997.9 ± 10.4 985.6 1025.6 1.00 ± 0.01
head poseidon_integration_benchmark 994.0 ± 4.7 986.9 1001.4 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.895 ± 0.016 1.879 1.931 1.00
head secp_integration_benchmark 1.901 ± 0.019 1.879 1.936 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 758.4 ± 11.8 750.1 788.6 1.01 ± 0.02
head set_integration_benchmark 754.6 ± 4.5 748.3 762.6 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.798 ± 0.118 4.667 5.058 1.00
head uint256_integration_benchmark 4.801 ± 0.142 4.667 5.168 1.00 ± 0.04

@fmoletta fmoletta force-pushed the range_check96_mod_integration_test branch from 7664e65 to d3b03f3 Compare April 10, 2024 17:19
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.90%. Comparing base (95d2c88) to head (669ab5f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1699   +/-   ##
=======================================
  Coverage   94.90%   94.90%           
=======================================
  Files          98       98           
  Lines       38103    38103           
=======================================
  Hits        36161    36161           
  Misses       1942     1942           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmoletta fmoletta changed the title (Dont Merge before deps) Add integration test using range_check96, add_mod & mul_mod builtins Add integration test using range_check96, add_mod & mul_mod builtins Apr 10, 2024
@fmoletta fmoletta marked this pull request as ready for review April 10, 2024 20:24
@pefontana pefontana enabled auto-merge April 16, 2024 14:53
@pefontana pefontana added this pull request to the merge queue Apr 16, 2024
Merged via the queue into main with commit 6ff8126 Apr 16, 2024
70 checks passed
@pefontana pefontana deleted the range_check96_mod_integration_test branch April 16, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Implementation of tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants