Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cairo_lang to 0.13.1 in testing env #1687

Merged
merged 5 commits into from
Mar 26, 2024
Merged

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Mar 25, 2024

Bumps cairo_lang to 0.13.1 in requirements.txt file
Updates cairo 0 programs
Implements 2 new hints

Copy link

github-actions bot commented Mar 25, 2024

Benchmark Results for modified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
head big_factorial 2.283 ± 0.015 2.249 2.303 1.00
Command Mean [s] Min [s] Max [s] Relative
head big_fibonacci 2.277 ± 0.021 2.258 2.320 1.00
Command Mean [s] Min [s] Max [s] Relative
head blake2s_integration_benchmark 8.647 ± 0.225 8.404 9.228 1.00
Command Mean [s] Min [s] Max [s] Relative
head compare_arrays_200000 2.398 ± 0.040 2.338 2.461 1.00
Command Mean [s] Min [s] Max [s] Relative
head dict_integration_benchmark 1.469 ± 0.016 1.451 1.510 1.00
Command Mean [s] Min [s] Max [s] Relative
head field_arithmetic_get_square_benchmark 1.320 ± 0.021 1.295 1.368 1.00
Command Mean [s] Min [s] Max [s] Relative
head integration_builtins 8.582 ± 0.154 8.378 8.971 1.00
Command Mean [s] Min [s] Max [s] Relative
head keccak_integration_benchmark 8.798 ± 0.186 8.627 9.284 1.00
Command Mean [s] Min [s] Max [s] Relative
head linear_search 2.397 ± 0.029 2.354 2.445 1.00
Command Mean [s] Min [s] Max [s] Relative
head math_cmp_and_pow_integration_benchmark 1.632 ± 0.033 1.582 1.676 1.00
Command Mean [s] Min [s] Max [s] Relative
head math_integration_benchmark 1.437 ± 0.011 1.423 1.458 1.00
Command Mean [s] Min [s] Max [s] Relative
head memory_integration_benchmark 1.300 ± 0.039 1.271 1.401 1.00
Command Mean [s] Min [s] Max [s] Relative
head operations_with_data_structures_benchmarks 1.646 ± 0.025 1.617 1.696 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
head pedersen 603.0 ± 8.4 594.0 622.0 1.00
Command Mean [s] Min [s] Max [s] Relative
head poseidon_integration_benchmark 1.004 ± 0.009 0.990 1.022 1.00
Command Mean [s] Min [s] Max [s] Relative
head secp_integration_benchmark 1.898 ± 0.026 1.868 1.940 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
head set_integration_benchmark 704.5 ± 8.5 696.4 720.5 1.00
Command Mean [s] Min [s] Max [s] Relative
head uint256_integration_benchmark 4.683 ± 0.057 4.602 4.754 1.00

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 13.33333% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 96.61%. Comparing base (72f0bad) to head (8d6ac20).

❗ Current head 8d6ac20 differs from pull request most recent head 66be88f. Consider uploading reports for the commit 66be88f to get more accurate results

Files Patch % Lines
...processor/builtin_hint_processor/poseidon_utils.rs 0.00% 11 Missing ⚠️
...int_processor/builtin_hint_processor_definition.rs 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1687      +/-   ##
==========================================
- Coverage   96.64%   96.61%   -0.04%     
==========================================
  Files          95       95              
  Lines       38375    38390      +15     
==========================================
+ Hits        37087    37089       +2     
- Misses       1288     1301      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmoletta fmoletta marked this pull request as ready for review March 25, 2024 15:35
@juanbono juanbono added this pull request to the merge queue Mar 26, 2024
Merged via the queue into main with commit 44de614 Mar 26, 2024
51 checks passed
@juanbono juanbono deleted the update-cairo_lang-0.13.1 branch March 26, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants