feat: Reorganized builtins to be in the top of stack at the end of run.

[orizi]

Builtins on top of stack at the end of cairo1 runs.

Description

Removed the extra wrapping function call, and make a single wrapping entrypoint code, that also copies data into the output_ptr if required, and then rewrites all the builtins (used and unused to top of stack).

This hopefully will make the running of the proof more usable.

[pefontana]

Thank you for the PR, @orizi !

I've noticed that this change introduces some issues when running programs in cairo-1 with --proof_mode. When we execute a Cairo 1 program with proof_mode, the execution never completes. Do you have any insights on why this might be happening?

cd cairo1-run
cp ../cairo_programs/cairo-1-programs/fibonacci.cairo ./

cargo run \
fibonacci.cairo \
--layout=small \
--air_public_input=fibonacci_public_input.json \
--air_private_input=fibonacci_private_input.json \
--trace_file=fibonacci_trace.json \
--memory_file=fibonacci_memory.json \
--print_output \
--proof_mode

[orizi]

Found the culprit and fixed as well.

[pefontana]

Great @orizi !
The Fibonacci program is working all right, but some programs still throw InvalidStopPointerIndex Error for the range check or Pedersen builtins. We will dive a little and try to fix them

[fmoletta]

Hello! We noticed some problems when running with proof_mode and when serializing outputs that makes tests fail, I sent a PR to your branch with fixes for these issues orizi#1

[codecov]

Codecov Report

Attention: Patch coverage is 96.36364% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 96.55%. Comparing base (22a97dc) to head (759bda0).
Report is 1 commits behind head on main.

Files	Patch %	Lines
cairo1-run/src/cairo_run.rs	96.36%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1686      +/-   ##
==========================================
- Coverage   96.56%   96.55%   -0.02%     
==========================================
  Files          95       95              
  Lines       38380    38406      +26     
==========================================
+ Hits        37062    37081      +19     
- Misses       1318     1325       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.