Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cairo1-run dependencies to deps & deps-macos targets #1466

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Oct 17, 2023

Currently, the fresh-run workflow is failing whenmake test is ran. This is due to cairo1-run crate tests having their own dependencies (aka the corelib setup), and them not being installed when running make deps(-macos).
This PR adds these dependencies to the deps(-macos) targets, solving this problem
Closes #1465 #1464 #1463 #1462

@fmoletta fmoletta added the pipelines This PR/issue is exclusively about improving our CI label Oct 17, 2023
@fmoletta fmoletta marked this pull request as ready for review October 17, 2023 13:41
@github-actions
Copy link

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 3.593 ± 0.019 3.565 3.616 1.00
head big_factorial 3.614 ± 0.018 3.572 3.641 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 3.043 ± 0.023 3.002 3.068 1.00
head big_fibonacci 3.050 ± 0.016 3.025 3.070 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 8.124 ± 0.042 8.077 8.192 1.00 ± 0.01
head blake2s_integration_benchmark 8.123 ± 0.112 7.973 8.385 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 3.037 ± 0.012 3.018 3.053 1.00
head compare_arrays_200000 3.048 ± 0.011 3.027 3.069 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.127 ± 0.012 2.108 2.144 1.01 ± 0.01
head dict_integration_benchmark 2.115 ± 0.006 2.105 2.125 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.566 ± 0.012 1.551 1.590 1.01 ± 0.01
head field_arithmetic_get_square_benchmark 1.551 ± 0.010 1.539 1.565 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.041 ± 0.081 7.950 8.187 1.00
head integration_builtins 8.066 ± 0.063 8.000 8.195 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.280 ± 0.083 8.182 8.386 1.01 ± 0.01
head keccak_integration_benchmark 8.220 ± 0.039 8.154 8.276 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 3.117 ± 0.016 3.099 3.152 1.01 ± 0.01
head linear_search 3.075 ± 0.014 3.054 3.098 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 2.233 ± 0.007 2.223 2.244 1.00
head math_cmp_and_pow_integration_benchmark 2.253 ± 0.025 2.233 2.319 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.026 ± 0.007 2.016 2.037 1.00
head math_integration_benchmark 2.046 ± 0.006 2.037 2.055 1.01 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.821 ± 0.003 1.816 1.826 1.00 ± 0.00
head memory_integration_benchmark 1.817 ± 0.004 1.812 1.823 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.003 ± 0.010 1.987 2.022 1.00
head operations_with_data_structures_benchmarks 2.035 ± 0.035 2.010 2.132 1.02 ± 0.02
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 765.5 ± 2.4 761.1 769.0 1.00 ± 0.00
head pedersen 765.1 ± 1.3 763.6 767.3 1.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.501 ± 0.004 1.497 1.509 1.00
head poseidon_integration_benchmark 1.512 ± 0.009 1.506 1.538 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 2.526 ± 0.015 2.512 2.567 1.00
head secp_integration_benchmark 2.536 ± 0.010 2.523 2.555 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.302 ± 0.014 1.295 1.341 1.00
head set_integration_benchmark 1.310 ± 0.002 1.306 1.313 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 5.468 ± 0.027 5.436 5.516 1.00
head uint256_integration_benchmark 5.531 ± 0.041 5.491 5.628 1.01 ± 0.01

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #1466 (e2aa4f7) into main (4598416) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1466   +/-   ##
=======================================
  Coverage   96.84%   96.84%           
=======================================
  Files          94       94           
  Lines       39003    39003           
=======================================
  Hits        37772    37772           
  Misses       1231     1231           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pefontana pefontana added this pull request to the merge queue Oct 17, 2023
Merged via the queue into main with commit f434823 Oct 17, 2023
@pefontana pefontana deleted the add-cairo1-run-deps branch October 17, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pipelines This PR/issue is exclusively about improving our CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WARNING fresh_run workflow failure
3 participants