-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: default program attributes to empty vec #1450
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oppen
requested review from
igaray,
fmoletta,
entropidelic,
juanbono,
pefontana and
Juan-M-V
as code owners
September 29, 2023 20:11
Oppen
force-pushed
the
fix/default_for_no_attrs
branch
from
September 29, 2023 20:36
0974ab8
to
96467e6
Compare
Benchmark Results for unmodified programs 🚀
|
Codecov Report
@@ Coverage Diff @@
## main #1450 +/- ##
=======================================
Coverage 96.99% 96.99%
=======================================
Files 93 93
Lines 38773 38791 +18
=======================================
+ Hits 37606 37624 +18
Misses 1167 1167
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
juanbono
approved these changes
Oct 2, 2023
pefontana
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows removing a special case in SiR and is arguably more correct in general.
Checklist