CairoPieValidation to #[error(transparent)] (#1761)

* CairoPieValidation #[error(transparent)] * Add warning --------- Co-authored-by: Pedro Fontana <[email protected]>
lambdaclass · May 10, 2024 · f87be4d · f87be4d
1 parent 9ef2ab8
commit f87be4d
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/vm/src/vm/errors/cairo_run_errors.rs b/vm/src/vm/errors/cairo_run_errors.rs
@@ -7,7 +7,9 @@ use crate::types::errors::program_errors::ProgramError;
 use crate::vm::errors::{
     runner_errors::RunnerError, trace_errors::TraceError, vm_errors::VirtualMachineError,
 };
-
+// In case you need to add a CairoRunError enum variant
+// Add it with #[error(transparent)]
+// If not it can cause some performance regressions, like in https://github.com/lambdaclass/cairo-vm/pull/1720
 #[derive(Debug, Error)]
 pub enum CairoRunError {
     #[error(transparent)]
@@ -22,6 +24,6 @@ pub enum CairoRunError {
     MemoryError(#[from] MemoryError),
     #[error(transparent)]
     VmException(#[from] VmException),
-    #[error("Cairo Pie validation failed: {0}")]
+    #[error(transparent)]
     CairoPieValidation(#[from] CairoPieValidationError),
 }