Skip to content

Commit

Permalink
chore: bump starknet-crypto to v0.6.1 (#1469)
Browse files Browse the repository at this point in the history
The new version contains a bug fix on ECDSA signature verification.
Previously, the `s` range was incorrectly enforced to be lower than
EC order instead of element bound. While this did not allow invalid
signatures to be used, it was theoretically possible (1 in 2^48
signatures) to have a signature that passes `verify` yet cannot be
proven (due to being out of element bound).
  • Loading branch information
xJonathanLEI authored Oct 31, 2023
1 parent e7ca592 commit 0d41042
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 14 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

#### Upcoming Changes

* chore: bump starknet-crypto to v0.6.1 [#1469](https://github.com/lambdaclass/cairo-vm/pull/1469)

* feat: Implement the Serialize and Deserialize methods for the Program struct [#1458](https://github.com/lambdaclass/cairo-vm/pull/1458)

* feat: Use only program builtins when running cairo 1 programs [#1457](https://github.com/lambdaclass/cairo-vm/pull/1457)
Expand Down
17 changes: 4 additions & 13 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ hex = { version = "0.4.3", default-features = false }
bincode = { version = "2.0.0-rc.3", default-features = false, features = [
"serde",
] }
starknet-crypto = { version = "0.5.0", default-features = false, features = [
starknet-crypto = { version = "0.6.1", default-features = false, features = [
"signature-display",
"alloc",
] }
Expand Down

1 comment on commit 0d41042

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.

Benchmark suite Current: 0d41042 Previous: e7ca592 Ratio
parse program 24484145 ns/iter (± 1020337) 18570130 ns/iter (± 408228) 1.32

This comment was automatically generated by workflow using github-action-benchmark.

CC: @unbalancedparentheses

Please sign in to comment.