Attempt to save settings on exit for all Things #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intention was that `thing_settings` would be saved on write - but this does not yet work. I now explicitly save to disk when the server exits cleanly.
rwb27
force-pushed
the
persist-settings-to-disk
branch
from
4980b70 to
aee61db
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
==========================================
- Coverage 79.93% 79.79% -0.15%
==========================================
Files 28 28
Lines 1630 1638 +8
==========================================
+ Hits 1303 1307 +4
- Misses 327 331 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Testing will need to be added in a future MR, for settings more generally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
thing_settingsobject is currently discarded when the server stops, unless it's been explicitly saved. We now attempt to save it.Future versions may save it only if it's non-empty, which would be neater.