Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): add irsa support #2

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

jaygridley
Copy link
Member

Description

Type of change

  • A bug fix (PR prefix fix)
  • A new feature (PR prefix feat)
  • A code change that neither fixes a bug nor adds a feature (PR prefix refactor)
  • Adding missing tests or correcting existing tests (PR prefix test)
  • Changes that do not affect the meaning of the code like white-spaces, formatting, missing semi-colons, etc. (PR prefix style)
  • Changes to our CI configuration files and scripts (PR prefix ci)
  • Documentation only changes (PR prefix docs)

How Has This Been Tested?

  • I added the IRSA role with the IAM policy, allowing the pulling of images from ECR when the controller is scheduled on a node with hop count = 1. Without IRSA, the controller cannot pull image metadata to determine the image entry point/command.

@jaygridley jaygridley added the enhancement New feature or request label Apr 8, 2024
@jaygridley jaygridley self-assigned this Apr 8, 2024
@jaygridley jaygridley requested a review from dojci April 8, 2024 09:18
Copy link
Member

@dojci dojci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dojci dojci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing controller irsa role attributes output

variables-controller.tf Outdated Show resolved Hide resolved
@jaygridley jaygridley force-pushed the fix/controller-irsa branch from a3579a1 to 2cc3a23 Compare April 9, 2024 05:51
@jaygridley jaygridley merged commit cc933b1 into main Apr 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants