-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix airgap deploy #260
fix airgap deploy #260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just small remarks. Otherwise it looks OK. Also please resolve the conflicts.
e2d5c90
to
9cd3979
Compare
oops i messed up a bit sorry, i'll fix soon |
I'm eagerly looking forward for this PR to be merged. Currently the airgap install doesn't work for me, this PR appears to be the salvation. |
Thanks for saying that! I'll get it done ASAP! It's so encouraging to hear. If you can do it faster than me, just submit a pr to my pr 🙂 it might take a few more days or a whole week or so
…________________________________
From: Elias Abacioglu ***@***.***>
Sent: Friday, November 1, 2024 5:04:40 PM
To: lablabs/ansible-role-rke2 ***@***.***>
Cc: simonfelding ***@***.***>; Author ***@***.***>
Subject: Re: [lablabs/ansible-role-rke2] fix airgap deploy (PR #260)
I'm eagerly looking forward for this PR to be merged. Currently the airgap install doesn't work for me, this PR appears to be the salvation.
—
Reply to this email directly, view it on GitHub<#260 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKYOW72AERRO3BSQWGAUKKLZ6ORBRAVCNFSM6AAAAABPW6SSO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJSGEZTCMJSGQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
I can try if I manage. Whats the status on your PR? What is missing or not working? |
I did run your fork today. requirements.yml: - src: https://github.com/simonfelding/ansible-role-rke2
version: "fix-airgap"
name: lablabs.rke2 The airgapped install seems to have worked fine.
|
@MonolithProjects Hi, what is needed for this PR to be merged? |
@Raboo I thought I had messed up something when I did that force push but it seems to be fine? idk. lgtm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
added better support for airgap mode 'exists' in rke2.yml
Part of splitting up #203
Type of change
How Has This Been Tested?
by rolling it out on an airgapped system multiple times