Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix airgap deploy #260

Merged
merged 2 commits into from
Nov 4, 2024
Merged

fix airgap deploy #260

merged 2 commits into from
Nov 4, 2024

Conversation

simonfelding
Copy link

@simonfelding simonfelding commented Oct 10, 2024

Description

added better support for airgap mode 'exists' in rke2.yml
Part of splitting up #203

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Small minor change not affecting the Ansible Role code (GitHub Actions Workflow, Documentation etc.)

How Has This Been Tested?

by rolling it out on an airgapped system multiple times

@MonolithProjects MonolithProjects self-assigned this Oct 26, 2024
@MonolithProjects MonolithProjects added the enhancement New feature or request label Oct 26, 2024
Copy link
Collaborator

@MonolithProjects MonolithProjects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small remarks. Otherwise it looks OK. Also please resolve the conflicts.

tasks/rke2.yml Outdated Show resolved Hide resolved
tasks/rke2.yml Outdated Show resolved Hide resolved
@simonfelding
Copy link
Author

oops i messed up a bit sorry, i'll fix soon

@Raboo
Copy link
Contributor

Raboo commented Nov 1, 2024

I'm eagerly looking forward for this PR to be merged. Currently the airgap install doesn't work for me, this PR appears to be the salvation.

@simonfelding
Copy link
Author

simonfelding commented Nov 1, 2024 via email

@Raboo
Copy link
Contributor

Raboo commented Nov 4, 2024

I can try if I manage. Whats the status on your PR? What is missing or not working?

@Raboo
Copy link
Contributor

Raboo commented Nov 4, 2024

I did run your fork today.

requirements.yml:

- src: https://github.com/simonfelding/ansible-role-rke2
  version: "fix-airgap"
  name: lablabs.rke2

The airgapped install seems to have worked fine.

$ kubectl get nodes
NAME                  STATUS   ROLES                       AGE     VERSION
sincere-boar-dev      Ready    control-plane,etcd,master   4h57m   v1.30.5+rke2r1
touching-guinea-dev   Ready    control-plane,etcd,master   5m5s    v1.30.5+rke2r1
welcomed-zebra-dev    Ready    control-plane,etcd,master   5m18s   v1.30.5+rke2r1

@Raboo
Copy link
Contributor

Raboo commented Nov 4, 2024

@MonolithProjects Hi, what is needed for this PR to be merged?

@simonfelding
Copy link
Author

@Raboo I thought I had messed up something when I did that force push but it seems to be fine? idk. lgtm.

Copy link
Collaborator

@MonolithProjects MonolithProjects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MonolithProjects MonolithProjects merged commit fe5c10f into lablabs:main Nov 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants