Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove old nodes when restoring etcd #257

Merged
merged 2 commits into from
Oct 31, 2024
Merged

remove old nodes when restoring etcd #257

merged 2 commits into from
Oct 31, 2024

Conversation

simonfelding
Copy link

Description

removes old nodes when restoring etcd

Part of splitting up #203

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Small minor change not affecting the Ansible Role code (GitHub Actions Workflow, Documentation etc.)

How Has This Been Tested?

@MonolithProjects MonolithProjects self-assigned this Oct 26, 2024
@MonolithProjects MonolithProjects added the enhancement New feature or request label Oct 26, 2024
MonolithProjects
MonolithProjects approved these changes Oct 26, 2024
View reviewed changes
Copy link
Collaborator

@MonolithProjects MonolithProjects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@simonfelding
Copy link
Author

@MonolithProjects cool! I think you forgot to merge :)

@MonolithProjects MonolithProjects merged commit a79ff8d into lablabs:main Oct 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonolithProjects MonolithProjects MonolithProjects approved these changes

Assignees

@MonolithProjects MonolithProjects

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonfelding @MonolithProjects