simplify rke2 artifact path #256
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonolithProjects
requested changes
Oct 23, 2024
defaults/main.yml
Outdated
| @@ -136,7 +136,7 @@ rke2_tarball_images_path: "{{ rke2_data_path }}/agent/images" | |||
| rke2_architecture: amd64 | |||
|
|
|||
| # Destination directory for RKE2 installation script | |||
| rke2_install_script_dir: /var/tmp | |||
| rke2_install_script_dir: "{{ rke2_install_script_dir }}" | |||
There was a problem hiding this comment.
You're right, nice catch. My brain must have turned off while making that commit.
|
You're right, nice catch. My brain must have turned off while making that commit. Fixed it. |
MonolithProjects
requested changes
Dec 18, 2024
| @@ -143,7 +143,7 @@ rke2_data_path: /var/lib/rancher/rke2 | |||
| rke2_artifact_url: https://github.com/rancher/rke2/releases/download/ | |||
|
|
|||
| # Local path to store artifacts | |||
| rke2_artifact_path: /rke2/artifact | |||
| rke2_artifact_path: /var/tmp | |||
There was a problem hiding this comment.
If we are gonna change it, let's change it to the path which is used in the RKE2 Docs https://docs.rke2.io/install/airgap (/root/rke2-artifacts)
| @@ -174,7 +174,7 @@ rke2_tarball_images_path: "{{ rke2_data_path }}/agent/images" | |||
| rke2_architecture: amd64 | |||
|
|
|||
| # Destination directory for RKE2 installation script | |||
| rke2_install_script_dir: /var/tmp | |||
| rke2_install_script_dir: "{{ rke2_artifact_path }}" | |||
There was a problem hiding this comment.
This can stay as it is (/var/tmp).
| @@ -105,7 +105,7 @@ rke2_data_path: /var/lib/rancher/rke2 | |||
| rke2_artifact_url: https://github.com/rancher/rke2/releases/download/ | |||
|
|
|||
| # Local path to store artifacts | |||
| rke2_artifact_path: /rke2/artifact | |||
| rke2_artifact_path: /var/tmp | |||
There was a problem hiding this comment.
If we are gonna change it, let's change it to the path which is used in the RKE2 Docs https://docs.rke2.io/install/airgap (/root/rke2-artifacts)
| @@ -136,7 +136,7 @@ rke2_tarball_images_path: "{{ rke2_data_path }}/agent/images" | |||
| rke2_architecture: amd64 | |||
|
|
|||
| # Destination directory for RKE2 installation script | |||
| rke2_install_script_dir: /var/tmp | |||
| rke2_install_script_dir: "{{ rke2_artifact_path }}" | |||
There was a problem hiding this comment.
This can stay as it is (/var/tmp).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a more linux-y path to put temporary files.
Part of splitting up #203
Type of change
How Has This Been Tested?