Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configuation option for cluster-domain #232

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

CrimsonFez
Copy link
Contributor

Description

I added an option to specify the cluster domain and updated the documentation for the change.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Small minor change not affecting the Ansible Role code (GitHub Actions Workflow, Documentation etc.)

How Has This Been Tested?

I haven't been able to get the molecule tests to work because I'm using podman instead of docker. If this is an issue please let me know.

Copy link
Collaborator

@MonolithProjects MonolithProjects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the Readme file with new variable. Thanks

@MonolithProjects MonolithProjects self-assigned this Jun 12, 2024
@MonolithProjects MonolithProjects added the enhancement New feature or request label Jun 12, 2024
@CrimsonFez
Copy link
Contributor Author

Anything else?

Copy link
Collaborator

@MonolithProjects MonolithProjects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MonolithProjects MonolithProjects merged commit a5c0c6c into lablabs:main Jun 13, 2024
5 checks passed
@CrimsonFez CrimsonFez deleted the add-cluster-domain branch June 13, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants