Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add cilium helm chart #236

Closed
villadalmine opened this issue Jun 30, 2024 · 5 comments
Closed

feature: add cilium helm chart #236

villadalmine opened this issue Jun 30, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@villadalmine
Copy link

Summary

I want to add support to deploy cilium with extra values with helmchart-config

Issue Type

Feature Idea

@villadalmine villadalmine added the enhancement New feature or request label Jun 30, 2024
@hoangphuocbk
Copy link
Contributor

You can create your customized manifest files as the document (https://docs.rke2.io/helm), then declare these files to rke2_custom_manifests

@villadalmine
Copy link
Author

villadalmine commented Jul 4, 2024

So the PR I created it is not needed if I am not wrong , because I want to use the helchartoption from rke2 with their helmchart,
It is not clear you have ingress custom yaml Jinja file , and it is the same approach for custom rke2 manifest, looks duplicated

@villadalmine
Copy link
Author

I think there is one difference between using rke2_custom_manifest and use rke2 helmchartconfig where are maintained by rke2

The helmchart integration in rke2 it is about the crd helmchart for external helmchart and the helmchartconfig for rke2 helmchart . What I m trying to add and request is kind of support to add more rke2 helmchartconfig in the bootstrapping

@MonolithProjects
Copy link
Collaborator

MonolithProjects commented Jul 25, 2024

Hi @villadalmine, @hoangphuocbk is right. You can just use rke2_custom_manifests which is being used in the code much earlier stage as your addition in #237 . You can see it here in the main file

- name: Download and install RKE2 {{ rke2_version }}
ansible.builtin.include_tasks: rke2.yml
and then here
- name: Copy Custom Manifests
ansible.builtin.template:
src: "{{ item }}"
dest: "{{ rke2_data_path }}/server/manifests/"
owner: root
group: root
mode: 0644
with_items: "{{ rke2_custom_manifests }}"
when: rke2_custom_manifests

#237

@villadalmine
Copy link
Author

Ok, more standard , you can close it, and keep doing it, it is amazing implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants