Custom Thresholds #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added exception and testcase
remove threshold number type unless needed
|
@f-hkobin Thanks for this, I will review and merge or get back to you if any changes are necessary soon. |
made `Viewed` facts static so that they occur in one timestep and stay active throughout the program.
|
@dyumanaditya Thanks for working upon the PR. Seems like the pipeline failed as shown in above details. |
|
I will try and merge it this weekend or before. The check failing is weird since I'm not able to reproduce it locally |
dyumanaditya
approved these changes
May 16, 2024
|
@f-hkobin @KaminiAggarwal Fixed the issue and merging, this will be in the next release |
|
Thank you @dyumanaditya ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom Thresholds
Addresses #50 and #49
Thresholdclass that is constrained to the shape mentioned in Do we have an estimate on when this might be picked up or guidance on how can contribute. #50pyreason/scripts/utils/rule_parser.pyto handle custom thresholds (or use the default threshold if not defined)We also worked on a numba type for the threshold, but I don't think it's needed in this current iteration, so we removed it.
Please let us know if modifications are needed and we will be happy to help, myself or Kamini will jump in to make changes 👍