-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.0.0 Grounding Improvement #14
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith [0,1] for all nodes. This makes labels.yaml' obsolete.
TODO: Fix issue with all nodes not having list of reversed neighbors |
# Conflicts: # pyreason/scripts/interpretation/interpretation.py
This was
linked to
issues
Jun 11, 2023
… rule trace as pd dataframe instead of saving directly
…nd no edge->node, node->edge predicate comparison
…nding-improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR the grounding process in PyReason will change. After this, we will release PyReason v2.0.0, where rules can be input in text format, making the YAMLs obsolete.
pred(x)<-pred1(y,x), pred2(y,z)
is different frompred(x,y)<-pred1(y,x), pred2(y,z)
. This should be reflected in the YAMLs as well#
and remove any blank linestarget_criteria
interpretation.py
Model
class for pyreason instead of global variables. Include functions such asmodel.summary()
after reasoning.diffuse.py
and command line supportinterpretations
as a dict instead of class objectprev_l
andprev_u
in interval class__source
in edge rule node clausesCurrently PyReason loops through all nodes and edges and checks for neighbor groundings. This is inflexible with rules such as
pred(x)<-pred1(y,x), pred2(y,z)
wherey
will be replaced by the neighbors ofx
--where in reality this should be any other node (except in the case of a node clause, then the groundings are the neighbors).