Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create All the most important terms from A-Z #26

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Nefn-Lakhouj
Copy link

No description provided.

@gelilaa gelilaa self-requested a review October 9, 2021 14:51
Copy link
Member

@gelilaa gelilaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nefn-Lakhouj can you please fix the conflict?

@Nefn-Lakhouj
Copy link
Author

@gelilaa i fix the cconfict
is it ok now?

Copy link
Member

@arnochauveau arnochauveau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@@ -1,107 +0,0 @@
# About Repository
Copy link
Member

@arnochauveau arnochauveau Dec 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't delete files please :-)
You can re-add this file by executing git checkout origin main -- admin/seeds/README.md

@@ -0,0 +1,568 @@
# All the most important terms from A-Z
Copy link
Member

@arnochauveau arnochauveau Dec 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file has no extension (should be a MD file) it's also bad practice to have spaces in filenames.
Also: all the newlines make it really hard to read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants