Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding vocabulary #20

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Adding vocabulary #20

wants to merge 3 commits into from

Conversation

sannesofie
Copy link
Contributor

@sannesofie sannesofie commented Oct 6, 2021

I am adding this vocabulary !

@colevandersWands
Copy link
Member

@sannesofie , can you split this into two separate PRs? One for your bio and one for the vocab. One PR should be one thing, this makes it easier to discuss and to make small changes in the repo

@sannesofie sannesofie added this to the workflows milestone Oct 8, 2021
@sannesofie sannesofie added the help wanted Extra attention is needed label Oct 10, 2021
@sannesofie
Copy link
Contributor Author

@gelilaa Here do I have to make a new PR for the vocabulary to pass the lint check or can I do something here to fix it?

@gelilaa
Copy link
Member

gelilaa commented Oct 11, 2021

@gelilaa Here do I have to make a new PR for the vocabulary to pass the lint check or can I do something here to fix it?

just a small change, it can be a space at the end of the sentence and push the change. Remember to check that you are on the right branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants