Refactor ContainerStats to contain all perf stats in one field #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update fork
katarzyna-z
approved these changes
Oct 8, 2020
katarzyna-z
suggested changes
Oct 8, 2020
| @@ -226,7 +226,7 @@ func TestContainerStatsToPoints(t *testing.T) { | |||
| points := storage.containerStatsToPoints(cInfo, stats) | |||
| points = append(points, storage.memoryStatsToPoints(cInfo, stats)...) | |||
| points = append(points, storage.hugetlbStatsToPoints(cInfo, stats)...) | |||
| points = append(points, storage.perfStatsToPoints(cInfo, stats)...) | |||
| points = append(points, storage.Perf.PerfStatsToPoints(cInfo, stats)...) | |||
There was a problem hiding this comment.
PerfStatsToPoints does not exist.
Have you run tests for InfluxDB? Have you seen this instruction?
Please check tests also for other storages.
There was a problem hiding this comment.
Tests work now. Other storages do not have tests. I've manually tested stdout and statsd
Signed-off-by: Wisniewski, Krzysztof2 <[email protected]>
kwisniewski98
force-pushed
the
perf_struct
branch
from
6787aaf to
24dfff7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wisniewski, Krzysztof2 [email protected]