Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Unify the planning order #165

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

kurosakishigure
Copy link
Owner

Description

  • What is the purpose of this PR?
    • Unify the planning order
  • What problem does it solve?
  • Are there any breaking changes or backwards compatibility issues?

Related Issue

Type of Change

  • Miscellaneous tasks

How Has This Been Tested?

  • I have run unit tests
  • I have tested the changes manually
  • I have tested in a staging environment

Checklist

  • I have read and followed the guidelines in CONTRIBUTING.md
  • I have already updated the related templates accordingly (if applicable)
  • I have written or updated relevant documentation (if applicable)
  • I have added or updated tests to cover my changes (if applicable)
  • I have reviewed my code for any potential issues

Additional Notes

This approach doesn't make much sense, but we aim to standardize the sequence of steps in the workflows.

@github-actions github-actions bot added the chore Miscellaneous tasks label Dec 30, 2024
@kurosakishigure
Copy link
Owner Author

kurosakishigure commented Dec 30, 2024

Additionally, the previous caching error in cd.yml was caused by the order of the Checkout step. However, since cd.yml usually only runs once, I decided to disable(#162) rust-cache for it:

Error: The process '/Users/runner/.cargo/bin/cargo' failed with exit code 101
    at ExecState._setResult (/Users/runner/work/_actions/Swatinem/rust-cache/v2/dist/restore/index.js:9728:25)
    at ExecState.CheckComplete (/Users/runner/work/_actions/Swatinem/rust-cache/v2/dist/restore/index.js:9711:18)
    at ChildProcess.<anonymous> (/Users/runner/work/_actions/Swatinem/rust-cache/v2/dist/restore/index.js:9605:27)
    at ChildProcess.emit (node:events:519:28)
    at maybeClose (node:internal/child_process:1105:16)
    at Socket.<anonymous> (node:internal/child_process:457:11)
    at Socket.emit (node:events:519:28)
    at Pipe.<anonymous> (node:net:339:12) {
  commandFailed: {
    command: 'cargo metadata --all-features --format-version 1 --no-deps',
    stderr: '\x1B[1m\x1B[31merror\x1B[0m\x1B[1m:\x1B[0m could not find `Cargo.toml` in `/Users/runner/work/katharsis/katharsis` or any parent directory\n'
  }
}

@kurosakishigure kurosakishigure merged commit 3d19752 into canary Dec 30, 2024
24 checks passed
@kurosakishigure kurosakishigure deleted the chore/unify_the_planning_order branch December 30, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Miscellaneous tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant