Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: Removed the redundant shared key and id #105

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

kurosakishigure
Copy link
Owner

@kurosakishigure kurosakishigure commented Dec 19, 2024

Description

  • What is the purpose of this PR?
  • What problem does it solve?
    • Removed the redundant shared key and id
  • Are there any breaking changes or backwards compatibility issues?
    • None

Related Issue

None.

Type of Change

Please delete options that are not relevant:

  • Reverts commit

How Has This Been Tested?

  • I have run unit tests
  • I have tested the changes manually
  • I have tested in a staging environment

Checklist

  • My code follows the coding style guidelines of this project
  • I have written or updated relevant documentation (if applicable)
  • I have added or updated tests to cover my changes (if applicable)
  • All new and existing tests pass
  • I have reviewed my code for any potential issues
  • Link the relevant issue to this PR (if applicable)
  • Add labels to this PR
  • I have read and followed the guidelines in CONTRIBUTING.md

Additional Notes

None.

@kurosakishigure kurosakishigure added the revert Reverts commit label Dec 19, 2024
@kurosakishigure
Copy link
Owner Author

Due to our limited understanding of shared caching, we currently do not plan to implement this feature. As a result, we have reverted commit 34f76cd.

@kurosakishigure kurosakishigure merged commit 8194200 into canary Dec 19, 2024
14 checks passed
@kurosakishigure kurosakishigure deleted the revert/102 branch December 19, 2024 13:58
@kurosakishigure
Copy link
Owner Author

kurosakishigure commented Dec 19, 2024

Unfortunately, based on the test results of #103 and #104, the shared key is not working. Hopefully, enthusiastic contributors will help us implement this feature in the future :)

@kurosakishigure kurosakishigure changed the title Revert "feat: Add the shared key to the rust-cache" revert(#102): Removed the redundant shared key and id Dec 22, 2024
@kurosakishigure kurosakishigure changed the title revert(#102): Removed the redundant shared key and id revert: Removed the redundant shared key and id Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
revert Reverts commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant