Skip to content

Commit

Permalink
fixes andy-portmen#72: Firefox open-in-chrome does not work with URLs…
Browse files Browse the repository at this point in the history
… that contain start word.
  • Loading branch information
kuntashov committed Nov 10, 2022
1 parent 8109785 commit 709c1e8
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions common/common.js
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,10 @@ const open = (urls, closeIDs = []) => {
exec(prefs.path, [...(app.runtime.windows.args2 || []), ...urls], r => response(r, close));
}
else {
const args = app.runtime.windows.args
.map(a => a.replace('%url;', urls.join(' ')))
// Firefox is not detaching the process on Windows
.map(s => s.replace('start', isFirefox ? 'start /WAIT' : 'start'));
const args = [...app.runtime.windows.args];
// Firefox is not detaching the process on Windows
args[1] = args[1].replace('start', isFirefox ? 'start /WAIT' : 'start');
args[2] = args[2].replace('%url;', urls.join(' '));
exec(app.runtime.windows.name, args, res => {
// use old method
if (res && res.code !== 0) {
Expand Down

0 comments on commit 709c1e8

Please sign in to comment.