feat(metrics): support OpenMetrics from applications #7103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If mediatype is text/plain, return Prometheus text format without checking the version param. Signed-off-by: AyushSenapati <[email protected]>
If application supports openmetrics format, attempt to make envoy stats compatible with openmetrics format Signed-off-by: AyushSenapati <[email protected]>
Signed-off-by: AyushSenapati <[email protected]>
AyushSenapati
changed the title
AyushSenapati
force-pushed
the
openmetrics-merge
branch
from
743fba9 to
b648f49
Compare
Signed-off-by: AyushSenapati <[email protected]>
michaelbeaumont
changed the title
There was a problem hiding this comment.
@AyushSenapati can you do me a favor and base this PR off the reverted commit? So the first commit would be a revert of the revert. A lot of the original PR still makes sense and it'd make it easier to review what's new since that PR.
| @@ -342,6 +376,7 @@ func responseFormat(h http.Header) expfmt.Format { | |||
| case textType: | |||
| return expfmt.FmtText | |||
|
|
|||
| // TODO: if version does not match or set, should we return FmtUnknown? | |||
There was a problem hiding this comment.
Yes, we can expect the open metric format to have a version I think.
|
@AyushSenapati can we close this PR in favor of #7125 then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist prior to review
closes: #7093
syscall.Mkfifohave equivalent implementation on the other OS --UPGRADE.md? --> Changelog:entry here or add aci/label to run fewer/more tests?