Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper Downloads directory location #16

Merged

Conversation

pa-sowa
Copy link
Contributor

@pa-sowa pa-sowa commented Apr 27, 2024

The location of the Downloads directory should not be hardcoded which will work only for English locale.

@daPhipz
Copy link
Contributor

daPhipz commented Apr 27, 2024

Thanks for your contribution!
Well spotted - in German (my system's language), this folder is called "Downloads" as well, so this problem didn't occur to me.

Would you please edit the comment above the variable declaration in KubuQA.conf as well? And both the comment and the variable declaration in KubuQA.conf need changing as well.
Once these changes are done, LGTM!

@pa-sowa
Copy link
Contributor Author

pa-sowa commented May 3, 2024

I implemented the requested changes.

@ricktimmis
Copy link
Collaborator

Hey @pa-sowa Thank You for your contribution. I hadn't consider that at all, Great Catch. This intrigued me so I did a little research and came across this.
https://www.freedesktop.org/wiki/Software/xdg-user-dirs/

This is a nice improvement, LGTM, let's Ship It!

@ricktimmis ricktimmis merged commit b6e9f8a into kubuntu-team:main May 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants