-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Learning paths #425
base: main
Are you sure you want to change the base?
Learning paths #425
Conversation
Signed-off-by: John Krug <[email protected]>
✅ Deploy Preview for silly-bunny-8cedd0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: John Krug <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a good addition, but maybe is enough with a page as I don't expect each persona to have a lot of content. The table/index is a good idea even if everything is in one page.
Signed-off-by: John Krug <[email protected]>
Signed-off-by: John Krug <[email protected]>
Signed-off-by: John Krug <[email protected]>
Signed-off-by: John Krug <[email protected]>
Signed-off-by: John Krug <[email protected]>
Moving to review, still in draft. Any further feedback? Relevant pages at https://deploy-preview-425--silly-bunny-8cedd0.netlify.app/next/learnpaths/paths |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGMT. But I don't think is necessary to have the location in the tables. The type should be enough. As the table has the links, I do not see the purpose to have the link path in the table. I'll never copy it if I have the link in the same row.
Yeah, still messing around with the available data and how to present it best. I think I need to work on a more tree like presentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, but I have some comments.
If possible for the autogenerated pages, I would prefer to list links in the same order as they are on the left section (first tutorials, then explanations, how-tos, and last reference).
Yes, working on that sort of thing. |
Signed-off-by: John Krug <[email protected]>
Signed-off-by: John Krug <[email protected]>
Signed-off-by: John Krug <[email protected]>
Signed-off-by: John Krug <[email protected]>
New frontmatter.
First draft. To take a look at learning paths.
Two questions: