governance, kubevirt, org: remove inactive users #3283
Conversation
|
Skipping CI for Draft Pull Request. |
kubevirt-bot
added
do-not-merge/work-in-progress
|
Thanks, this is a great idea! +1 Cleanup, and if there is an impact,then rather add users again. |
kubevirt-bot
removed
the
do-not-merge/work-in-progress
|
/cc @aburdenthehand I think we should add a paragraph in the member_dd section that adds the things from the PR. |
|
|
+1 FYI, @AdamJ @adityaramteke @alonSadan @alosadagrande @andreyod @ArthurSens @ashleyschuett @bardielle @beanh66 @beekhof @booxter @borod108 @brybacki @crobinso @cynepco3hahue @danielBelenky @danielerez @dcritch @djzager @doron-fediuck @dshchedr @dteplits @duyanyan @eedri @e-minguez @erkanerol @ezrasilvera @fabiendupont @fedepaol @fgimenez @gabrielecerami @gbenhaim @gonzolino @gsr-shanks @guy9050 @hritvi @hroyrh @humblenginr @ibesso-rh @idanshaby @ifireball @igoihman @ILpinto @InbarRose @iranzo @irosenzw @isaacdorfman @itamarh @jakub-dzon @jelkosz @j-griffith @jhernand @JinjunXiong @jniederm @jordigilh @jparrill @jtomasek @krsacme @kubevirt-commenter-bot @kwiesmueller @lukas-bednar @lveyde @machacekondra @mansam @marceloamaral @mareklibra @MarSik @masayag @matosatti @matthewcarleton @maya-r @mazzystr @michalskrivanek @mlsorensen @mmazur @mmirecki @mshitrit @myakove @n1r1 @nellyc @nelsonspbr @nertpinx @nirarg @ohadlevy @omeryahud @pcbailey @petrkotas @pkliczewski @ptrnull @qwang1 @ravidbro @rawagner @razo7 @rgolangh @rhrazdil @rnetser @rollandf @ronensdeor @sandrobonazzola @sarahbx @SchSeba @scollier @screeley44 @serenamarie125 @sgarbour @shiywang @shwetaap @simon3z @slintes @sreichar @stbenjam @stoniko @suomiy @tareqalayan @thetechnick @tomob @usrbinkat @vatsalparekh @vojtechszocs @xphyr @yanirq @yossisegev @yuhaohaoyu @yuvalif @yuvalturg @zcahana @zvikorn |
|
The last time I committed anything to the project was August 2020 (kubevirt.github.io) and have no issues with being removed based on the reasoning. If there is anything that I can contribute to I'd be happy to jump back in. |
|
Same thing here, I was made a member thanks to a mentorship I did back in 2020 with the kubevirt community and I haven't contributed since the mentorship ended. I have no issues with the removal I appreciate your time @dhiller, @fabiand, @danielBelenky and the community for all the wisdom shared! |
|
/hold need to fix the script removing the bot user |
kubevirt-bot
added
the
do-not-merge/hold
dhiller
force-pushed
the
remove-users-without-contributions
branch
from
d7e694c to
da6eb79
Compare
|
/unhold commenter-bot removal reverted |
kubevirt-bot
removed
the
do-not-merge/hold
|
I don't think we need a confirmation from every member affected, since it's a reflection of reality, and no one should be offended by reality. :) But +1 just in case this may help to move the change forward. It makes sense for projects to keep their rosters current. |
kubevirt-bot
added
the
needs-rebase
dhiller
force-pushed
the
remove-users-without-contributions
branch
from
da6eb79 to
9ef09a9
Compare
kubevirt-bot
removed
the
needs-rebase
|
/release-note chore: remove inactive members |
|
/release-note-edit |
There was a problem hiding this comment.
This is an awesome cleanup, thank you!
Note: Devstats does not take into account non-code contributions.
Does this mean that active reviewers or approves can still be removed?
I would expect active approvers not to be removed, even if they do not author PRs. They also have a dedicated removal policy which includes OWNER files changes.
BTW, what will happen to the members in the OWNERs files in the different projects and folders?
I'm more thinking over time, like in the in months/years to come when this script runs again and picks up more inactive people. Presumably then it would only be a couple at a time. |
I Agree. I actually created the PR and description manually, besides the script consuming the csv data file there's no automation currently. We would need to discuss in which intervals we want to do this chore anyhow. But I think that we can refine this then. WDYT? |
|
/lgtm |
|
/approve It was great seeing old the former faces in this thread again! 👋 People are always welcome back, thus let's move on. |
It was mentioned in the k8s cleanup issue that somehow there should be a memorial for people having moved on from the project, in order to honor their contributions. I think we might do the same on kubevirt.io. WDYT @fabiand @aburdenthehand ? |
|
Sounds good. |
|
dhiller
force-pushed
the
remove-users-without-contributions
branch
from
9ef09a9 to
4baef86
Compare
|
/retest |
|
@dhiller Looks like there's a limit that we're exceeding to how many members you can remove in one PR: https://storage.googleapis.com/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/3283/pull-kubevirt-org-github-config-updater/1766082766576816128/build-log.txt |
|
Can I get another lgtm please? And probably an approval if we are good with this cleanup? |
@aburdenthehand yeah, that's just a security measure from the tool in order to no accidentally remove too many people. But we should override this one for once. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brianmcarey, fabiand The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/unhold |
kubevirt-bot
removed
the
do-not-merge/hold
|
/override pull-kubevirt-org-github-config-updater |
|
@dhiller: Overrode contexts on behalf of dhiller: pull-kubevirt-org-github-config-updater In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* governance, kubevirt, org: create script Adds a script that can be used to automate the process for removing users from the org that have no contributions according to the input file. Input file is taken from KubeVirt devstats. Signed-off-by: Daniel Hiller <[email protected]> * governance, KubeVirt, org: remove inactive users Removes users without contributions within the last twelve months. Input data for contributions taken from KubeVirt devstats: https://kubevirt.devstats.cncf.io/d/48/users-statistics-by-repository-group?orgId=1&from=now-1y&to=now&var-period=w&var-metric=activity&var-repogroup_name=All&var-users=All&inspect=1&inspectTab=data Signed-off-by: Daniel Hiller <[email protected]> --------- Signed-off-by: Daniel Hiller <[email protected]>
What this PR does / why we need it:
Removes inactive users from the org.
Announcement to kubevirt-dev
Also adds a script that can be used to automate the process of removing
users from the org that have no contributions according to the input
file.
List of removed users:
Inactive members
Members are active contributors in the community.
A core principle in maintaining a healthy community is encouraging active
participation. It is inevitable that people's focuses will change over time and
they are not expected to be actively contributing forever.
However, being a member of the KubeVirt GitHub organization comes with
an elevated set of permissions. These capabilities should not be used by those
that are not familiar with the current state of the KubeVirt project.
Therefore members with an extended period away from the project with no activity
will be removed from the KubeVirt GitHub Organizations and will be required to
go through the org membership process again after re-familiarizing themselves
with the current state.
How inactivity is measured
Inactive members are defined as members of the KubeVirt Organization
with no contributions in any repository within 12 months. This is
measured by the CNCF DevStats project.
Note: Devstats does not take into account non-code contributions. If a
non-code contributing member is accidentally removed this way, they may open an
issue to quickly be re-instated.
After an extended period away from the project with no activity
those members would need to re-familiarize themselves with the current state
before being able to contribute effectively.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
[ ] Design: A design document was considered and is present (link) or not required[ ] Code: Write code that humans can understand and Keep it simple[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.Release note: