-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more details and examples for platform configuration #78
Add more details and examples for platform configuration #78
Conversation
Enhanced the comments to provide more clarity on how to configure platforms for multi-platform builds. Signed-off-by: Ashok Pariya <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @ashokpariya0. Thanks for your PR. I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
cc @oshoval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
For visibility, the real reason is that we need a new release now that the publish job was changed.
We would also need a tag afterwards please
cc @phoracek |
/approved |
Thanks for the contribution. I have released https://github.com/kubevirt/bridge-marker/releases/tag/0.12.0 |
@phoracek Thank you so much! I can now see that the multi-platform supported images are available at Quay. I also did a quick sanity check on s390x, and everything looks good to me. |
Enhanced the comments to provide more clarity on how to configure platforms for multi-platform builds.
What this PR does / why we need it:
Enhanced comments to provide more details on setting platforms for multi-platform image builds.
Added examples for configuring PLATFORMS and using the PLATFORM_LIST variable.
Clarified the default behavior (builds based on the host architecture).
Provided options for setting specific platforms or using all to include all supported platforms.
Special notes for your reviewer:
For clarity, the main reason is that we need a new release following the changes made to the publish job in PR:
kubevirt/project-infra#3819.
Release note: