Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more details and examples for platform configuration #78

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

ashokpariya0
Copy link
Contributor

@ashokpariya0 ashokpariya0 commented Dec 12, 2024

Enhanced the comments to provide more clarity on how to configure platforms for multi-platform builds.

What this PR does / why we need it:
Enhanced comments to provide more details on setting platforms for multi-platform image builds.
Added examples for configuring PLATFORMS and using the PLATFORM_LIST variable.
Clarified the default behavior (builds based on the host architecture).
Provided options for setting specific platforms or using all to include all supported platforms.

Special notes for your reviewer:
For clarity, the main reason is that we need a new release following the changes made to the publish job in PR:
kubevirt/project-infra#3819.

Release note:

None

Enhanced the comments to provide more clarity on how to configure
platforms for multi-platform builds.

Signed-off-by: Ashok Pariya <[email protected]>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 12, 2024
@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign phoracek for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot requested a review from RamLavi December 12, 2024 09:46
@kubevirt-bot kubevirt-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 12, 2024
@kubevirt-bot
Copy link

Hi @ashokpariya0. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ashokpariya0
Copy link
Contributor Author

cc @oshoval

Copy link
Collaborator

@oshoval oshoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

For visibility, the real reason is that we need a new release now that the publish job was changed.
We would also need a tag afterwards please

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2024
@ashokpariya0
Copy link
Contributor Author

cc @phoracek

@phoracek
Copy link
Member

/approved

@phoracek phoracek merged commit a2c347b into kubevirt:main Dec 12, 2024
3 of 4 checks passed
@phoracek
Copy link
Member

Thanks for the contribution. I have released https://github.com/kubevirt/bridge-marker/releases/tag/0.12.0

@ashokpariya0
Copy link
Contributor Author

Thanks for the contribution. I have released https://github.com/kubevirt/bridge-marker/releases/tag/0.12.0

@phoracek Thank you so much! I can now see that the multi-platform supported images are available at Quay. I also did a quick sanity check on s390x, and everything looks good to me.
@oshoval I really appreciate all your help, thorough reviews, and attention to detail. Your effort has been invaluable, and I’m grateful for your support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants