Handle potential nil pointer in handleSnapshot

If the dataimportcron status has an empty currentImports, the returned PVC will be nil and handleSnapshot will be called. handleSnapshot should check for nil PVC before proceeding. Signed-off-by: Alexander Wels <[email protected]>
kubevirt-bot · Nov 6, 2024 · 4420a3a · 4420a3a
1 parent 4b76c3c
commit 4420a3a
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/pkg/controller/dataimportcron-controller.go b/pkg/controller/dataimportcron-controller.go
@@ -700,6 +700,9 @@ func (r *DataImportCronReconciler) handleCronFormat(ctx context.Context, dataImp
 }
 
 func (r *DataImportCronReconciler) handleSnapshot(ctx context.Context, dataImportCron *cdiv1.DataImportCron, pvc *corev1.PersistentVolumeClaim, desiredStorageClass *storagev1.StorageClass) error {
+	if pvc == nil {
+		return nil
+	}
 	if sc := pvc.Spec.StorageClassName; sc != nil && *sc != desiredStorageClass.Name {
 		r.log.Info("Attempt to change storage class, will not try making a snapshot of the old PVC")
 		return nil