Skip to content

Commit

Permalink
pkg/importer: Increase number of nbdkit lines logged (kubevirt#3376)
Browse files Browse the repository at this point in the history
30 is far too small.  For "chatty" plugins like VDDK many more
debugging lines will be printed for simple open calls.  For debugging
it is vital that we do not lose this information.  Ideally I would set
this to infinity.

Related: https://issues.redhat.com/browse/CNV-44894

Signed-off-by: Richard W.M. Jones <[email protected]>
Co-authored-by: Richard W.M. Jones <[email protected]>
  • Loading branch information
kubevirt-bot and rwmjones authored Aug 8, 2024
1 parent 2fffa8f commit 2909564
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/importer/vddk-datasource_amd64.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ var newNbdKitLogWatcher = createNbdKitLogWatcher
const (
nbdUnixSocket = "/tmp/nbd.sock"
nbdPidFile = "/tmp/nbd.pid"
maxLogLines = 30
maxLogLines = 1000
)

var vddkVersion string
Expand Down

0 comments on commit 2909564

Please sign in to comment.