[wip] SmartState analysis POC #119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borod108
force-pushed
the
feature/smartstatepoc
branch
3 times, most recently
from
41c138c to
fcbc9c1
Compare
the container exposes a service that recieves the cluster credentials, runs the smartstate and will return the results as a bulk when done. Signed-off-by: borod108 <[email protected]>
borod108
force-pushed
the
feature/smartstatepoc
branch
from
fcbc9c1 to
f668069
Compare
tupyy
reviewed
Jan 13, 2025
| @@ -6,8 +6,8 @@ GO_FILES := $(shell find ./ -name ".go" -not -path "./bin" -not -path "./packagi | |||
| GO_CACHE := -v $${HOME}/go/migration-planner-go-cache:/opt/app-root/src/go:Z -v $${HOME}/go/migration-planner-go-cache/.cache:/opt/app-root/src/.cache:Z | |||
| TIMEOUT ?= 30m | |||
| VERBOSE ?= false | |||
| MIGRATION_PLANNER_AGENT_IMAGE ?= quay.io/kubev2v/migration-planner-agent | |||
| MIGRATION_PLANNER_API_IMAGE ?= quay.io/kubev2v/migration-planner-api | |||
| MIGRATION_PLANNER_AGENT_IMAGE ?= quay.io/bodnopoz/migration-planner-agent | |||
There was a problem hiding this comment.
please keep the defaul kubev2v
tupyy
reviewed
Jan 13, 2025
| MIGRATION_PLANNER_AGENT_IMAGE ?= quay.io/kubev2v/migration-planner-agent | ||
| MIGRATION_PLANNER_API_IMAGE ?= quay.io/kubev2v/migration-planner-api | ||
| MIGRATION_PLANNER_AGENT_IMAGE ?= quay.io/bodnopoz/migration-planner-agent | ||
| MIGRATION_PLANNER_API_IMAGE ?= quay.io/bodnopoz/migration-planner-api |
tupyy
reviewed
Jan 13, 2025
| id: id, | ||
| jwt: jwt, | ||
| config: config, | ||
| healthCheckStopCh: make(chan chan any), |
There was a problem hiding this comment.
Please make a separate PR for this.
tupyy
reviewed
Jan 13, 2025
| credUrl string | ||
| id uuid.UUID | ||
| jwt string | ||
| config *config.Config |
There was a problem hiding this comment.
is the file formatted? gopls maybe?
| require 'json' | ||
| require 'manageiq-smartstate' | ||
| # boot.rb | ||
| $LOAD_PATH << File.expand_path("/home/bodnopoz/work/manageiq-gems-pending/lib", __FILE__) |
There was a problem hiding this comment.
I guess, this needs to be fixed?
tupyy
reviewed
Jan 13, 2025
| @@ -152,6 +152,16 @@ func (a *Agent) start(ctx context.Context, plannerClient client.Planner) { | |||
| continue | |||
| } | |||
|
|
|||
| nsc := service.NewSmartStateClient() | |||
There was a problem hiding this comment.
This could be moved outside the loop.
tupyy
reviewed
Jan 13, 2025
| @@ -152,6 +152,16 @@ func (a *Agent) start(ctx context.Context, plannerClient client.Planner) { | |||
| continue | |||
| } | |||
|
|
|||
| nsc := service.NewSmartStateClient() | |||
| zap.S().Debug("trying to get smart state results") | |||
There was a problem hiding this comment.
this will pollute the log with an entry that does not add value to the logs.
tupyy
reviewed
Jan 13, 2025
|
|
||
| type SmartStateOption func(client *SmartStateClient) | ||
|
|
||
| func NewSmartStateClient(opts ...SmartStateOption) SmartStateClient { |
There was a problem hiding this comment.
You should return a pointer here. the methods are attached to a pointer to the type.
tupyy
reviewed
Jan 13, 2025
| } | ||
| } | ||
|
|
||
| func RemoveProtocolAndRoute(rawURL string) (string, error) { |
tupyy
reviewed
Jan 13, 2025
| defer resp.Body.Close() | ||
|
|
||
| if resp.StatusCode >= 200 && resp.StatusCode < 300 { | ||
| fmt.Println("Request succeeded with status:", resp.StatusCode) |
tupyy
reviewed
Jan 13, 2025
| return nil | ||
| } | ||
|
|
||
| return fmt.Errorf("request failed with status: %d", resp.StatusCode) |
There was a problem hiding this comment.
just a suggestion. It is common for the last return to be successful.
tupyy
reviewed
Jan 13, 2025
| return nil, fmt.Errorf("failed to decode JSON response: %w", err) | ||
| } | ||
|
|
||
| fmt.Println("Request succeeded with status:", resp.StatusCode) |
tupyy
reviewed
Jan 13, 2025
| defer resp.Body.Close() | ||
|
|
||
| if resp.StatusCode == 202 { | ||
| fmt.Println("Request in progress. Status:", resp.StatusCode) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add collection of additional data about the cluster using ManageIQ Smart State tool. This information is very invasive, it includes accounts, installed software etc. So this is just a POC which will be modified later to avoid gathering information we do not need. Also it takes a lot of time, about 30 seconds per VM on average.